1
0
mirror of https://github.com/golang/go synced 2024-11-18 08:14:41 -07:00
go/cmd
Chris Broadfoot 837e80568c godoc/proxy: remove use of httputil.ReverseProxy for /share
ReverseProxy doesn't re-set the Request's Host field, only
Request.URL.Host.
The HTTP/2 client prefers Request.Host over Request.URL.Host, so this
results in the request being sent back to the host that originally
accepted the request.
This results in an infinite redirect (and consumption of many connections to
itself).
See Issue golang/go#28168 for details.

Replace it with a simple proxy that drops all the headers (except
Content-Type).

I tried setting the proxy.Director, but it still didn't work. Could do
with some more investigation.

Fixes golang/go#28134.

Change-Id: I5051ce72a379dcacfbe8484f58f8cf7d9385024d
Reviewed-on: https://go-review.googlesource.com/c/141718
Run-TryBot: Chris Broadfoot <cbro@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
2018-12-12 17:29:21 +00:00
..
benchcmp benchmark/parser, cmd/benchcmp: improve names of exported identifiers 2015-01-15 01:28:17 +00:00
bundle cmd/bundle: change the behavior of the -underscore flag 2018-12-01 03:58:26 +00:00
callgraph go/ssa/ssautil: add AllPackages method 2018-10-15 18:41:29 +00:00
compilebench cmd/compilebench: fix GOROOT inconsistencies 2018-08-10 00:27:41 +00:00
cover cmd/cover: check os.Create error im html output 2017-01-08 00:00:17 +00:00
digraph cmd/digraph: print usage on -h 2018-08-20 20:10:23 +00:00
eg cmd/eg: Gofmt eg's dry-run output. 2017-07-13 04:09:46 +00:00
fiximports all: set GO111MODULE=off for tests that use GOPATHs in testdata. 2018-10-03 17:21:27 +00:00
getgo godoc,cmd/getgo: update download links to dl.google.com 2018-01-25 02:56:30 +00:00
go-contrib-init cmd/go-contrib-init: exit with an error if package install fails 2017-07-17 03:20:55 +00:00
godex x/tools: remove old renaming imports of go/constant as exact 2018-08-10 17:04:37 +00:00
godoc godoc/proxy: remove use of httputil.ReverseProxy for /share 2018-12-12 17:29:21 +00:00
goimports cmd/goimports: update Emacs install instructions 2018-11-30 05:20:23 +00:00
golsp cmd/golsp/integration/vscode: add language server client for testing 2018-12-10 22:45:52 +00:00
gomvpkg cmd/gomvpkg: add missing closing double-quote to documentation 2018-05-22 18:16:25 +00:00
gorename cmd/gorename: set GO111MODULE=off in gorename_test 2018-10-08 20:39:09 +00:00
gotype gotype: fix default importer for Go 1.8. 2017-04-10 16:28:46 +00:00
goyacc cmd/goyacc: put //line annotations on the first column. 2018-09-26 03:27:08 +00:00
guru cmd/guru: add type position to describe command 2018-11-20 20:06:22 +00:00
heapview cmd/heapview: look for tools repository in all GOPATH entries 2017-04-10 18:12:01 +00:00
html2article x/tools/cmd/html2article: remove unused functions 2017-03-01 14:53:04 +00:00
present cmd/present: address minor comments not applied in a previous change 2018-10-13 14:52:46 +00:00
ssadump go/ssa/ssautil: add AllPackages method 2018-10-15 18:41:29 +00:00
stress cmd/stress: prefix logs with start date/time 2018-11-27 19:52:27 +00:00
stringer cmd/stringer: accept simple type conversion expressions in constant ValueSpec 2018-11-01 07:19:27 +00:00
tip cmd/tip: enable playground on tip.golang.org 2018-11-02 05:00:50 +00:00
toolstash cmd/toolstash: don't try comparing "asm -V=full" output. 2017-11-02 22:54:56 +00:00