mirror of
https://github.com/golang/go
synced 2024-11-18 11:44:45 -07:00
8d86ef2216
For a failed interface conversion not in ",ok" form, getitab calls itab.init to get the name of the missing method for the panic message. itab.init will try to find the methods, populate the method table as it goes. When some method is missing, it sets itab.fun[0] to 0 before return. There is a small window that itab.fun[0] could be non-zero. If concurrently, another goroutine tries to do the same interface conversion, it will read the same itab's fun[0]. If this happens in the small window, it sees a non-zero fun[0] and thinks the conversion succeeded, which is bad. Fix the race by setting fun[0] to non-zero only when we know the conversion succeeds. While here, also simplify the syntax slightly. Fixes #31419. Change-Id: Ied34d3043079eb933e330c5877b85e13f98f1916 Reviewed-on: https://go-review.googlesource.com/c/go/+/171759 Run-TryBot: Cherry Zhang <cherryyz@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Keith Randall <khr@golang.org>
59 lines
948 B
Go
59 lines
948 B
Go
// run
|
|
|
|
// Copyright 2019 The Go Authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style
|
|
// license that can be found in the LICENSE file.
|
|
|
|
// Issue 31419: race in getitab when two goroutines try
|
|
// to do the same failed interface conversion.
|
|
|
|
package main
|
|
|
|
type T int
|
|
|
|
func (t T) M() {}
|
|
|
|
type I interface {
|
|
M()
|
|
M2()
|
|
}
|
|
|
|
var t T
|
|
var e interface{} = &t
|
|
var ok = false
|
|
var ch = make(chan int)
|
|
|
|
func main() {
|
|
_, ok = e.(I) // populate itab cache with a false result
|
|
|
|
go f() // get itab in a loop
|
|
|
|
var i I
|
|
for k := 0; k < 10000; k++ {
|
|
i, ok = e.(I) // read the cached itab
|
|
if ok {
|
|
println("iteration", k, "i =", i, "&t =", &t)
|
|
panic("conversion succeeded")
|
|
}
|
|
}
|
|
<-ch
|
|
}
|
|
|
|
func f() {
|
|
for i := 0; i < 10000; i++ {
|
|
f1()
|
|
}
|
|
ch <- 1
|
|
}
|
|
|
|
func f1() {
|
|
defer func() {
|
|
err := recover()
|
|
if err == nil {
|
|
panic("did not panic")
|
|
}
|
|
}()
|
|
i := e.(I) // triggers itab.init, for getting the panic string
|
|
_ = i
|
|
}
|