1
0
mirror of https://github.com/golang/go synced 2024-11-18 18:04:46 -07:00
go/internal/lsp
Rebecca Stambler 8110780cfa internal/lsp: add correct handling for circular imports
This change brings back handling for circular imports, which was removed
because I originally thought that go/packages would handle that.
However, since we are type-checking from source, we still end up having
to deal with that.

Additionally, we propagate the errors of type-checking to the
diagnostics so that the user can actually see some of the problems.

Change-Id: I0139bcaae461f1bcaf95706532bc5026f2430101
Reviewed-on: https://go-review.googlesource.com/c/tools/+/166882
Run-TryBot: Rebecca Stambler <rstambler@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Ian Cottrell <iancottrell@google.com>
2019-03-15 16:49:21 +00:00
..
cache internal/lsp: add correct handling for circular imports 2019-03-15 16:49:21 +00:00
cmd internal/lsp: convert to the new location library 2019-03-13 19:34:21 +00:00
diff internal/lsp/diff: fix bug that adds extra line to files on format 2019-02-13 04:28:36 +00:00
protocol internal/lsp: convert to the new location library 2019-03-13 19:34:21 +00:00
source internal/lsp: add correct handling for circular imports 2019-03-15 16:49:21 +00:00
testdata internal/lsp: remove handling for circular imports 2019-03-04 22:34:19 +00:00
completion.go internal/lsp: configure completion to preselect the first item 2019-03-15 04:42:04 +00:00
diagnostics.go internal/lsp: propagate errors from in diagnostics 2019-03-15 04:33:14 +00:00
format.go internal/lsp: handle common nil pointer exceptions 2019-03-13 23:43:22 +00:00
imports.go internal/lsp: handle common nil pointer exceptions 2019-03-13 23:43:22 +00:00
lsp110_test.go internal/lsp: add more testdata for completion and diagnostics 2018-11-20 06:06:34 +00:00
lsp_test.go internal/lsp: propagate errors from in diagnostics 2019-03-15 04:33:14 +00:00
server.go internal/lsp: convert to the new location library 2019-03-13 19:34:21 +00:00
signature_help.go internal/lsp: implement signature help 2018-11-13 20:09:34 +00:00