1
0
mirror of https://github.com/golang/go synced 2024-11-18 10:54:40 -07:00
go/internal/lsp
Rebecca Stambler 80cb79702c internal/lsp: don't publish duplicate diagnostics in one report
CL 242579 changed the mechanism of reporting diagnostics so that we now
combine reports from multiple sources. Previously, we overwrote existing
diagnostics if new ones were reported. This was fine because
source.Diagnostics generated all of the diagnostics for Go files, and
mod.Diagnostics generated all of the diagnostics for go.mod files.

Now, we combine diagnostics from both sources -- mod.Diagnostics can
generate reports for Go files. We may get duplicate reports for packages
with test variants, so now, we check for those and dedupe.

Change-Id: I42e98079b4eead380058dd029a3a0c72a1796ebb
Reviewed-on: https://go-review.googlesource.com/c/tools/+/243778
Run-TryBot: Rebecca Stambler <rstambler@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Heschi Kreinick <heschi@google.com>
2020-07-23 19:34:40 +00:00
..
analysis internal/lsp: move fillstruct suggested fixes out of analysis 2020-07-20 20:42:44 +00:00
browser
cache internal/lsp: support go mod tidy on save without diagnostics 2020-07-21 22:32:18 +00:00
cmd internal/lsp: support extract function 2020-07-20 18:55:41 +00:00
debug internal/lsp/lsprpc: improvements to daemon logging 2020-07-16 19:33:22 +00:00
diff internal/testenv: check that external 'diff' tool is the GNU version 2020-05-08 20:46:49 +00:00
fake internal/lsp: change the way that we pass arguments to command 2020-07-21 16:30:27 +00:00
fuzzy internal/lsp: fix errors found by staticcheck 2020-03-19 19:20:54 +00:00
helper internal/lsp: change to helper.go to output a formatted file 2020-01-31 20:35:38 +00:00
lsprpc internal/lsp/lsprpc: improvements to daemon logging 2020-07-16 19:33:22 +00:00
mod internal/lsp: support go mod tidy on save without diagnostics 2020-07-21 22:32:18 +00:00
protocol internal/lsp: change the way that we pass arguments to command 2020-07-21 16:30:27 +00:00
regtest internal/lsp: don't publish duplicate diagnostics in one report 2020-07-23 19:34:40 +00:00
snippet
source internal/lsp: separate test and benchmark codelens 2020-07-22 18:17:40 +00:00
testdata internal/lsp: separate test and benchmark codelens 2020-07-22 18:17:40 +00:00
tests internal/lsp: support extract function 2020-07-20 18:55:41 +00:00
code_action.go internal/lsp: support go mod tidy on save without diagnostics 2020-07-21 22:32:18 +00:00
code_lens.go internal/lsp: change the way that we pass arguments to command 2020-07-21 16:30:27 +00:00
command.go internal/lsp: separate test and benchmark codelens 2020-07-22 18:17:40 +00:00
completion_test.go internal/lsp/source: offer smart "append()" completions 2020-05-20 22:05:37 +00:00
completion.go internal/lsp: remove VS Code-specific completion hack 2020-06-30 15:48:51 +00:00
definition.go internal/lsp: read files eagerly 2020-06-11 22:11:59 +00:00
diagnostics.go internal/lsp: don't publish duplicate diagnostics in one report 2020-07-23 19:34:40 +00:00
folding_range.go internal/lsp: read files eagerly 2020-06-11 22:11:59 +00:00
format.go internal/lsp: read files eagerly 2020-06-11 22:11:59 +00:00
general.go internal/lsp: watch go.{mod,sum} files, as well as Go files 2020-07-13 01:13:07 +00:00
highlight.go internal/lsp: read files eagerly 2020-06-11 22:11:59 +00:00
hover.go internal/lsp: read files eagerly 2020-06-11 22:11:59 +00:00
implementation.go internal/lsp: read files eagerly 2020-06-11 22:11:59 +00:00
link.go internal/lsp: add an importShortcut configuration 2020-07-15 23:00:36 +00:00
lsp_test.go internal/lsp: don't publish duplicate diagnostics in one report 2020-07-23 19:34:40 +00:00
progress.go internal/lsp: change the way that we pass arguments to command 2020-07-21 16:30:27 +00:00
references.go internal/lsp: read files eagerly 2020-06-11 22:11:59 +00:00
rename.go internal/lsp: read files eagerly 2020-06-11 22:11:59 +00:00
reset_golden.sh
server_gen.go x/tools/gopls: add support for $/progress functionality 2020-03-16 21:25:24 +00:00
server.go internal/lsp: change the way that we pass arguments to command 2020-07-21 16:30:27 +00:00
signature_help.go internal/lsp: read files eagerly 2020-06-11 22:11:59 +00:00
symbols.go internal/lsp: read files eagerly 2020-06-11 22:11:59 +00:00
text_synchronization.go internal/lsp: don't keep track of closed overlays 2020-07-16 17:49:00 +00:00
workspace_symbol.go internal/lsp/source: add a new symbolStyle configuration option 2020-06-26 17:13:37 +00:00
workspace.go gopls, internal/lsp: support an extra formatting hook for gofumpt 2020-07-13 21:42:47 +00:00