1
0
mirror of https://github.com/golang/go synced 2024-09-30 14:18:32 -06:00
go/gopls/internal/hooks
Dominik Honnef 332987a829 gopls/internal/hooks: don't run staticcheck's SA5011
SA5011 relies on facts from dependencies to avoid false positives.
However, gopls currently only loads export data for dependencies, it
does not compute facts.

SA5011 is unlike other analyzers in staticcheck, which may produce
false negatives if facts are missing, but no false positives.

Change-Id: I5063b701bbedca7b09d1894997f8c574fa497939
Reviewed-on: https://go-review.googlesource.com/c/tools/+/228119
Run-TryBot: Dominik Honnef <dominik@honnef.co>
Reviewed-by: Rebecca Stambler <rstambler@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
2020-04-14 03:22:29 +00:00
..
analysis.go gopls/internal/hooks: don't run staticcheck's SA5011 2020-04-14 03:22:29 +00:00
diff_test.go gopls: use go-diff for edit generation 2019-10-10 20:18:25 +00:00
diff.go gopls: use go-diff for edit generation 2019-10-10 20:18:25 +00:00
hooks.go gopls: use mvdan.cc/xurls for textDocument/documentLink 2019-12-26 21:20:25 +00:00