1
0
mirror of https://github.com/golang/go synced 2024-11-16 21:14:44 -07:00
go/src
Austin Clements 7ee9980105 cmd/go: replace formatOutput/showOutput with reportCmd
The general pattern is to replace

	if len(cmdOut) > 0 {
		output := b.processOutput(cmdOut)
		if err != nil {
			err = formatOutput(b.WorkDir, dir, p.ImportPath, desc, output)
		} else {
			b.showOutput(a, dir, desc, output)
		}
	}
	if err != nil {
		return err
	}

with

	if err := b.reportCmd(a, p, desc, dir, cmdOut, err); err != nil {
		return err
	}

However, there is a fair amount of variation between call sites. The
most common non-trivial variation is sites where errors are an
expected outcome. In this case, often we simply pass "nil" for the
error to trigger only the printing behavior of reportCmd.

For #62067, but also a nice cleanup on its own.

Change-Id: Ie5f918017c02d8558f23ad4c38261077c0fa4ea3
Reviewed-on: https://go-review.googlesource.com/c/go/+/529219
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Bryan Mills <bcmills@google.com>
2023-10-18 14:06:33 +00:00
..
archive archive: add available godoc link 2023-10-13 18:36:46 +00:00
arena
bufio bufio: link "too large to fit" to Scanner.Buffer 2023-10-14 22:15:54 +00:00
builtin
bytes bytes,strings: add available godoc link 2023-10-13 17:10:31 +00:00
cmd cmd/go: replace formatOutput/showOutput with reportCmd 2023-10-18 14:06:33 +00:00
cmp
compress compress: some minor corrections or adjustments for godoc link 2023-10-13 23:20:03 +00:00
container container/heap: add available godoc link 2023-10-12 14:39:10 +00:00
context
crypto crypto: add available godoc link 2023-10-13 17:09:47 +00:00
database/sql
debug
embed
encoding encoding/xml: use reflect.Value.IsZero 2023-10-12 20:48:17 +00:00
errors
expvar expvar: add available godoc link 2023-10-13 20:31:53 +00:00
flag
fmt
go go/printer: fix invalid output for empty decls 2023-10-17 18:53:17 +00:00
hash hash: add available godoc link 2023-10-13 19:15:34 +00:00
html html/template: track brace depth for each nested expression 2023-10-16 03:29:27 +00:00
image
index/suffixarray index/suffixarray: add available godoc link 2023-10-13 19:15:06 +00:00
internal all: fix function names 2023-10-14 22:30:23 +00:00
io io/fs: add godoc links 2023-10-11 20:25:50 +00:00
log
maps maps: add examples for Clone,Copy and Equal 2023-10-11 20:21:56 +00:00
math
mime
net all: fix function names 2023-10-14 22:30:23 +00:00
os os: use strings.EqualFold in os_test.go 2023-10-09 22:06:42 +00:00
path
plugin
reflect reflect: compute the median h uniformly 2023-10-09 21:56:00 +00:00
regexp regexp: add godoc links 2023-10-11 20:23:37 +00:00
runtime runtime: fix comments for itab 2023-10-18 00:24:39 +00:00
slices
sort
strconv strconv: add example for QuotedPrefix 2023-10-13 22:57:37 +00:00
strings bytes,strings: add available godoc link 2023-10-13 17:10:31 +00:00
sync
syscall
testdata
testing testing/fstest: add godoc links 2023-10-11 20:21:27 +00:00
text
time all: fix function names 2023-10-14 22:30:23 +00:00
unicode
unsafe
vendor all: pull in x/net v0.17.0 and its dependencies 2023-10-10 16:32:44 +00:00
all.bash
all.bat
all.rc
bootstrap.bash
buildall.bash
clean.bash
clean.bat
clean.rc
cmp.bash
go.mod all: pull in x/net v0.17.0 and its dependencies 2023-10-10 16:32:44 +00:00
go.sum all: pull in x/net v0.17.0 and its dependencies 2023-10-10 16:32:44 +00:00
make.bash
make.bat
Make.dist
make.rc
race.bash
race.bat
README.vendor
run.bash
run.bat
run.rc

Vendoring in std and cmd
========================

The Go command maintains copies of external packages needed by the
standard library in the src/vendor and src/cmd/vendor directories.

There are two modules, std and cmd, defined in src/go.mod and
src/cmd/go.mod. When a package outside std or cmd is imported
by a package inside std or cmd, the import path is interpreted
as if it had a "vendor/" prefix. For example, within "crypto/tls",
an import of "golang.org/x/crypto/cryptobyte" resolves to
"vendor/golang.org/x/crypto/cryptobyte". When a package with the
same path is imported from a package outside std or cmd, it will
be resolved normally. Consequently, a binary may be built with two
copies of a package at different versions if the package is
imported normally and vendored by the standard library.

Vendored packages are internally renamed with a "vendor/" prefix
to preserve the invariant that all packages have distinct paths.
This is necessary to avoid compiler and linker conflicts. Adding
a "vendor/" prefix also maintains the invariant that standard
library packages begin with a dotless path element.

The module requirements of std and cmd do not influence version
selection in other modules. They are only considered when running
module commands like 'go get' and 'go mod vendor' from a directory
in GOROOT/src.

Maintaining vendor directories
==============================

Before updating vendor directories, ensure that module mode is enabled.
Make sure that GO111MODULE is not set in the environment, or that it is
set to 'on' or 'auto'.

Requirements may be added, updated, and removed with 'go get'.
The vendor directory may be updated with 'go mod vendor'.
A typical sequence might be:

    cd src
    go get golang.org/x/net@master
    go mod tidy
    go mod vendor

Use caution when passing '-u' to 'go get'. The '-u' flag updates
modules providing all transitively imported packages, not only
the module providing the target package.

Note that 'go mod vendor' only copies packages that are transitively
imported by packages in the current module. If a new package is needed,
it should be imported before running 'go mod vendor'.