mirror of
https://github.com/golang/go
synced 2024-10-01 11:28:34 -06:00
4dc11ae26b
Before this change, when DeepEqual checks values with cycle, it may
panic due to stack overflow.
Here is a sample to reproduce the issue.
makeCycleMap := func() interface{} {
cycleMap := map[string]interface{}{}
cycleMap["foo"] = cycleMap
return cycleMap
}
m1 := makeCycleMap()
m2 := makeCycleMap()
reflect.DeepEqual(m1, m2) // stack overflow
The root cause is that DeepEqual fails to cache interface values
in visited map, which is used to detect cycle. DeepEqual calls
CanAddr to check whether a value should be cached or not. However,
all values referenced by interface don't have flagAddr thus all these
values are not cached.
THe fix is to remove CanAddr calls and use underlying ptr in value
directly. As ptr is only read-only in DeepEqual for caching, it's
safe to do so. We don't use UnsafeAddr this time, because this method
panics when CanAddr returns false.
Fixes #33907
Change-Id: I2aa88cc060a2c2192b1d34c129c0aad4bd5597e7
Reviewed-on: https://go-review.googlesource.com/c/go/+/191940
Run-TryBot: Ian Lance Taylor <iant@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
|
||
|---|---|---|
| .. | ||
| all_test.go | ||
| asm_386.s | ||
| asm_amd64.s | ||
| asm_amd64p32.s | ||
| asm_arm64.s | ||
| asm_arm.s | ||
| asm_mips64x.s | ||
| asm_mipsx.s | ||
| asm_ppc64x.s | ||
| asm_s390x.s | ||
| asm_wasm.s | ||
| deepequal.go | ||
| example_test.go | ||
| export_test.go | ||
| makefunc.go | ||
| set_test.go | ||
| swapper.go | ||
| tostring_test.go | ||
| type.go | ||
| value.go | ||