mirror of
https://github.com/golang/go
synced 2024-11-18 22:14:56 -07:00
e31c80b82c
This CL got away from me a little. For a number of reasons, the existing goimports API of passing in values for various GO* values was not working. For one, the number of necessary variables kept growing. For another, we tried to avoid calling `go env` in GOPATH mode by using `build.Default`, but that turns out to be buggy; see golang/go#39838. And finally, it created massive confusion about whether the values were intended to be read from the OS environment, or fully evaluated by the `go` command. There are only two users of the internal imports API, so there really shouldn't need to be more than two modes. For the command line tool, we have to call `go env` to deal with the `go/build` bug. So we just do it. Tests use that same path, but can augment the enviroment to set themselves up. In contrast, `gopls` needs to fully specify the environment. It can simply pass in the fully evaluated GO* values. Finally, make the change I was actually here to make: propagate GOMODCACHE and use it where appropriate. Fixes golang/go#39761. Change-Id: I720c69839d91d66d98e94dfc5f065ba0279c5542 Reviewed-on: https://go-review.googlesource.com/c/tools/+/239754 Run-TryBot: Heschi Kreinick <heschi@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Rebecca Stambler <rstambler@golang.org>
61 lines
1.5 KiB
Go
61 lines
1.5 KiB
Go
// Copyright 2020 The Go Authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style
|
|
// license that can be found in the LICENSE file.
|
|
|
|
package regtest
|
|
|
|
import (
|
|
"testing"
|
|
|
|
"golang.org/x/tools/internal/lsp/tests"
|
|
"golang.org/x/tools/internal/testenv"
|
|
)
|
|
|
|
func TestModFileModification(t *testing.T) {
|
|
testenv.NeedsGo1Point(t, 14)
|
|
|
|
const proxy = `
|
|
-- example.com@v1.2.3/go.mod --
|
|
module example.com
|
|
|
|
go 1.12
|
|
-- example.com@v1.2.3/blah/blah.go --
|
|
package blah
|
|
|
|
const Name = "Blah"
|
|
`
|
|
const untidyModule = `
|
|
-- go.mod --
|
|
module mod.com
|
|
|
|
-- main.go --
|
|
package main
|
|
|
|
import "example.com/blah"
|
|
|
|
func main() {
|
|
fmt.Println(blah.Name)
|
|
}`
|
|
runner.Run(t, untidyModule, func(t *testing.T, env *Env) {
|
|
// Open the file and make sure that the initial workspace load does not
|
|
// modify the go.mod file.
|
|
goModContent := env.ReadWorkspaceFile("go.mod")
|
|
env.OpenFile("main.go")
|
|
env.Await(
|
|
env.DiagnosticAtRegexp("main.go", "\"example.com/blah\""),
|
|
)
|
|
if got := env.ReadWorkspaceFile("go.mod"); got != goModContent {
|
|
t.Fatalf("go.mod changed on disk:\n%s", tests.Diff(goModContent, got))
|
|
}
|
|
// Save the buffer, which will format and organize imports.
|
|
// Confirm that the go.mod file still does not change.
|
|
env.SaveBuffer("main.go")
|
|
env.Await(
|
|
env.DiagnosticAtRegexp("main.go", "\"example.com/blah\""),
|
|
)
|
|
if got := env.ReadWorkspaceFile("go.mod"); got != goModContent {
|
|
t.Fatalf("go.mod changed on disk:\n%s", tests.Diff(goModContent, got))
|
|
}
|
|
}, WithProxy(proxy))
|
|
}
|