Heschi Kreinick d926bd178c internal/lsp/cache: always type check in default mode ... Every package has a default type checking mode dictated by whether it's in the workspace or not. Some features force full rather than exported type checking, but AFAICT that ends up being more harm than good. For example, let's say we want to Find References on fmt.Printf in the stdlib. Before this CL, we'd force a new type check of the fmt package, then find no references because nothing else would have been checked against that new version. While there may be some features that work better in the current regime, I can't think of any, and we have no test coverage for them. So I'd rather start with what makes sense, and if we want to change it maybe let's write some tests. Change-Id: Iea589efb4b4374fd2a54451c868b6e2bd5484e20 Reviewed-on: https://go-review.googlesource.com/c/tools/+/248380 Run-TryBot: Heschi Kreinick <heschi@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Rebecca Stambler <rstambler@golang.org>		2020-08-13 18:10:07 +00:00
..
codelens_test.go	internal/lsp: correctly marshal arguments for upgrade code lens	2020-07-27 21:52:59 +00:00
definition_test.go	internal/lsp/regtest: put testing.T back in the test func signature	2020-04-14 18:42:46 +00:00
diagnostics_test.go	internal/lsp: add a configuration to limit workspace scope to root URI	2020-08-11 01:57:04 +00:00
doc.go	internal/lsp/regtest: add expository package documentation	2020-04-28 21:10:48 +00:00
env_test.go	internal/lsp: use the token supplied by the client for progress	2020-08-10 15:15:12 +00:00
env.go	internal/lsp: use the token supplied by the client for progress	2020-08-10 15:15:12 +00:00
fix_test.go	internal/lsp: move fillstruct suggested fixes out of analysis	2020-07-20 20:42:44 +00:00
formatting_test.go	gopls, internal/lsp: support an extra formatting hook for gofumpt	2020-07-13 21:42:47 +00:00
generate_test.go	internal/lsp/regtest: add support for testing generate commands	2020-05-04 19:25:30 +00:00
imports_test.go	internal/lsp/regtest: add run options to support stress testing	2020-07-23 23:37:37 +00:00
link_test.go	internal/lsp/regtest: add run options to support stress testing	2020-07-23 23:37:37 +00:00
modfile_test.go	internal/lsp: add errors for missing modules that don't map to an import	2020-07-24 00:18:24 +00:00
references_test.go	internal/lsp/cache: always type check in default mode	2020-08-13 18:10:07 +00:00
reg_test.go	internal/lsp/regtest: simpler way to invert options	2020-07-16 18:20:50 +00:00
runner.go	internal/lsp: add a configuration to limit workspace scope to root URI	2020-08-11 01:57:04 +00:00
shared_test.go	internal/lsp/regtest: add run options to support stress testing	2020-07-23 23:37:37 +00:00
stress_test.go	internal/lsp/regtest: add a simple stress test	2020-07-23 23:37:47 +00:00
symbol_helper_test.go	internal/lsp/fake: define Symbol method on Editor	2020-05-11 20:27:07 +00:00
symbol_test.go	internal/lsp/source: add a new symbolStyle configuration option	2020-06-26 17:13:37 +00:00
unix_test.go	internal/lsp: lift env out of the sandbox into the editor	2020-07-23 21:58:45 +00:00
vendor_test.go	internal/lsp/regtest: add run options to support stress testing	2020-07-23 23:37:37 +00:00
watch_test.go	internal/lsp: invalidate all packages on go.mod file changes	2020-07-31 06:09:45 +00:00
workspace_test.go	internal/lsp: watch directories in replace targets and update on changes	2020-08-07 23:35:17 +00:00
wrappers.go	internal/lsp: correctly invalidate metadata for batched changes	2020-07-27 19:55:46 +00:00