1
0
mirror of https://github.com/golang/go synced 2024-11-19 04:24:39 -07:00
go/internal/span/uri_windows_test.go
Rebecca Stambler 35ac94b00d internal/span, internal/lsp: fix URI escaping
We had previously worked around a VS Code URI bug by unescaping URIs.
This is incorrect, so stop doing it and then add a specific workaround
just for that one bug.

Fixes golang/go#36999

Change-Id: I92f1a5f71749af7a6b1020eee1272586515f7084
Reviewed-on: https://go-review.googlesource.com/c/tools/+/217599
Run-TryBot: Rebecca Stambler <rstambler@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Heschi Kreinick <heschi@google.com>
2020-02-04 00:54:49 +00:00

84 lines
2.4 KiB
Go

// Copyright 2020 The Go Authors. All rights reserved.
// Use of this source code is governed by a BSD-style
// license that can be found in the LICENSE file.
// +build windows
package span_test
import (
"testing"
"golang.org/x/tools/internal/span"
)
// TestURI tests the conversion between URIs and filenames. The test cases
// include Windows-style URIs and filepaths, but we avoid having OS-specific
// tests by using only forward slashes, assuming that the standard library
// functions filepath.ToSlash and filepath.FromSlash do not need testing.
func TestURI(t *testing.T) {
for _, test := range []struct {
path, wantFile string
wantURI span.URI
}{
{
path: ``,
wantFile: ``,
wantURI: span.URI(""),
},
{
path: `C:\Windows\System32`,
wantFile: `C:\Windows\System32`,
wantURI: span.URI("file:///C:/Windows/System32"),
},
{
path: `C:\Go\src\bob.go`,
wantFile: `C:\Go\src\bob.go`,
wantURI: span.URI("file:///C:/Go/src/bob.go"),
},
{
path: `c:\Go\src\bob.go`,
wantFile: `C:\Go\src\bob.go`,
wantURI: span.URI("file:///C:/Go/src/bob.go"),
},
{
path: `\path\to\dir`,
wantFile: `C:\path\to\dir`,
wantURI: span.URI("file:///C:/path/to/dir"),
},
{
path: `\a\b\c\src\bob.go`,
wantFile: `C:\a\b\c\src\bob.go`,
wantURI: span.URI("file:///C:/a/b/c/src/bob.go"),
},
{
path: `c:\Go\src\bob george\george\george.go`,
wantFile: `C:\Go\src\bob george\george\george.go`,
wantURI: span.URI("file:///C:/Go/src/bob%20george/george/george.go"),
},
{
path: `file:///c:/Go/src/bob%20george/george/george.go`,
wantFile: `C:\Go\src\bob george\george\george.go`,
wantURI: span.URI("file:///C:/Go/src/bob%20george/george/george.go"),
},
{
path: `file:///C%3A/Go/src/bob%20george/george/george.go`,
wantFile: `C:\Go\src\bob george\george\george.go`,
wantURI: span.URI("file:///C:/Go/src/bob%20george/george/george.go"),
},
{
path: `file:///c:/path/to/%25p%25ercent%25/per%25cent.go`,
wantFile: `C:\path\to\%p%ercent%\per%cent.go`,
wantURI: span.URI(`file:///C:/path/to/%25p%25ercent%25/per%25cent.go`),
},
} {
got := span.NewURI(test.path)
if got != test.wantURI {
t.Errorf("ToURI: got %s, expected %s", got, test.wantURI)
}
if got.Filename() != test.wantFile {
t.Errorf("Filename: got %s, expected %s", got.Filename(), test.wantFile)
}
}
}