mirror of
https://github.com/golang/go
synced 2024-11-06 04:26:11 -07:00
542ffc7e75
A few files have been forked and tagged "go1.5,!go1.6" to work around
minor API changes between the two types packages:
- constant.Value.String() in oracle/describe.go and its tests;
- constant.ToInt must now be called before constant.Int64Val.
- types.Config{Importer: importer.Default()} in a number of places
- go/types/typeutil/import_test.go uses lowercase names to avoid 'import "C"'.
Files in go/types/typesutil, missing from my previous CL, have been
tagged !go1.5; these files will be deleted in February.
All affected packages were tested using 1.4.1, 1.5, and ~1.6 (tip).
Change-Id: Iec7fd370e1434508149b378438fb37f65b8d2ba8
Reviewed-on: https://go-review.googlesource.com/18207
Reviewed-by: Robert Griesemer <gri@golang.org>
83 lines
1.7 KiB
Go
83 lines
1.7 KiB
Go
// Copyright 2014 The Go Authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style
|
|
// license that can be found in the LICENSE file.
|
|
|
|
/*
|
|
This file contains the code to check for suspicious shifts.
|
|
*/
|
|
|
|
package main
|
|
|
|
import (
|
|
"go/ast"
|
|
exact "go/constant"
|
|
"go/token"
|
|
"go/types"
|
|
)
|
|
|
|
func init() {
|
|
register("shift",
|
|
"check for useless shifts",
|
|
checkShift,
|
|
binaryExpr, assignStmt)
|
|
}
|
|
|
|
func checkShift(f *File, node ast.Node) {
|
|
switch node := node.(type) {
|
|
case *ast.BinaryExpr:
|
|
if node.Op == token.SHL || node.Op == token.SHR {
|
|
checkLongShift(f, node, node.X, node.Y)
|
|
}
|
|
case *ast.AssignStmt:
|
|
if len(node.Lhs) != 1 || len(node.Rhs) != 1 {
|
|
return
|
|
}
|
|
if node.Tok == token.SHL_ASSIGN || node.Tok == token.SHR_ASSIGN {
|
|
checkLongShift(f, node, node.Lhs[0], node.Rhs[0])
|
|
}
|
|
}
|
|
}
|
|
|
|
// checkLongShift checks if shift or shift-assign operations shift by more than
|
|
// the length of the underlying variable.
|
|
func checkLongShift(f *File, node ast.Node, x, y ast.Expr) {
|
|
v := f.pkg.types[y].Value
|
|
if v == nil {
|
|
return
|
|
}
|
|
amt, ok := exact.Int64Val(v)
|
|
if !ok {
|
|
return
|
|
}
|
|
t := f.pkg.types[x].Type
|
|
if t == nil {
|
|
return
|
|
}
|
|
b, ok := t.Underlying().(*types.Basic)
|
|
if !ok {
|
|
return
|
|
}
|
|
var size int64
|
|
var msg string
|
|
switch b.Kind() {
|
|
case types.Uint8, types.Int8:
|
|
size = 8
|
|
case types.Uint16, types.Int16:
|
|
size = 16
|
|
case types.Uint32, types.Int32:
|
|
size = 32
|
|
case types.Uint64, types.Int64:
|
|
size = 64
|
|
case types.Int, types.Uint, types.Uintptr:
|
|
// These types may be as small as 32 bits, but no smaller.
|
|
size = 32
|
|
msg = "might be "
|
|
default:
|
|
return
|
|
}
|
|
if amt >= size {
|
|
ident := f.gofmt(x)
|
|
f.Badf(node.Pos(), "%s %stoo small for shift of %d", ident, msg, amt)
|
|
}
|
|
}
|