1
0
mirror of https://github.com/golang/go synced 2024-11-18 18:34:40 -07:00
go/internal/lsp/cmd
Rob Findley 78d067421b internal/lsp: remove the Context argument from NewSession
The passed-in Context is not used, and creates the illusion of a startup
dependency problem: existing code is careful to pass in the context
containing the correct Client instance.

This allows passing in a source.Session, rather than a source.Cache,
into lsp server constructors.

Updates golang/go#34111

Change-Id: I081ad6fa800b846b63e04d7164577e3a32966704
Reviewed-on: https://go-review.googlesource.com/c/tools/+/215740
Run-TryBot: Robert Findley <rfindley@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Rebecca Stambler <rstambler@golang.org>
Reviewed-by: Ian Cottrell <iancottrell@google.com>
2020-01-21 23:07:03 +00:00
..
test internal/lsp: remove the Context argument from NewSession 2020-01-21 23:07:03 +00:00
capabilities_test.go internal/lsp: remove the Context argument from NewSession 2020-01-21 23:07:03 +00:00
check.go internal/lsp: remove boolean for publishEmpty in diagnostics 2020-01-15 22:25:09 +00:00
cmd_test.go internal/lsp: do not invoke the Go command when checking common errors 2020-01-17 21:23:25 +00:00
cmd.go internal/lsp: remove the Context argument from NewSession 2020-01-21 23:07:03 +00:00
definition.go internal/lsp: improve link in documentation on hover 2019-12-12 22:39:21 +00:00
export_test.go internal/lsp: refactor query definition test to allow adding a new test 2019-03-18 20:06:54 +00:00
folding_range.go tools/gopls: add cmd support for folding_ranges 2019-11-12 00:55:09 +00:00
format.go internal/lsp: address staticcheck warnings 2019-10-04 02:16:23 +00:00
highlight.go internal/lsp: add control flow highlighting for functions 2019-12-02 19:01:20 +00:00
implementation.go tools/gopls: add cmd support for implementation 2019-11-25 20:27:09 +00:00
imports.go internal/lsp: fix the return type of CodeAction() 2019-11-19 17:57:05 +00:00
info.go tools/internal/lsp/cmd: fix documentation 2019-12-30 18:10:14 +00:00
links.go tools/gopls: add command line support for links 2019-11-01 17:18:15 +00:00
query.go internal/lsp: improve link in documentation on hover 2019-12-12 22:39:21 +00:00
references.go internal/lsp: propagate errors from find references 2020-01-09 21:23:09 +00:00
rename.go internal/lsp/cmd: don't create .orig files for rename by default 2019-11-19 21:08:41 +00:00
serve.go internal/lsp: remove the Context argument from NewSession 2020-01-21 23:07:03 +00:00
signature.go tools/gopls: add cmd support for signature 2019-10-31 22:07:37 +00:00
suggested_fix.go internal/lsp: diagnose the snapshot on every text synchronization event 2020-01-15 23:07:48 +00:00
symbols.go internal/lsp/cmd: fix documentation 2020-01-02 17:13:01 +00:00