mirror of
https://github.com/golang/go
synced 2024-11-19 00:14:39 -07:00
788e038e5d
mustBe was barely over budget, so manually inlining the first flag.kind call is enough. Add a TODO to reverse that in the future, once the compiler gets better. mustBeExported and mustBeAssignable were over budget by a larger amount, so add slow path functions instead. This is the same strategy used in the sync package for common methods like Once.Do, for example. Lots of exported reflect.Value methods call these assert-like unexported methods, so avoiding the function call overhead in the common case does shave off a percent from most exported APIs. Finally, add the methods to TestIntendedInlining. While at it, replace a couple of uses of the 0 Kind with its descriptive name, Invalid. name old time/op new time/op delta Call-8 68.0ns ± 1% 66.8ns ± 1% -1.81% (p=0.000 n=10+9) PtrTo-8 8.00ns ± 2% 7.83ns ± 0% -2.19% (p=0.000 n=10+9) Updates #7818. Change-Id: Ic1603b640519393f6b50dd91ec3767753eb9e761 Reviewed-on: https://go-review.googlesource.com/c/go/+/166462 Run-TryBot: Daniel Martí <mvdan@mvdan.cc> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org> |
||
---|---|---|
.. | ||
all_test.go | ||
asm_386.s | ||
asm_amd64.s | ||
asm_amd64p32.s | ||
asm_arm64.s | ||
asm_arm.s | ||
asm_mips64x.s | ||
asm_mipsx.s | ||
asm_ppc64x.s | ||
asm_s390x.s | ||
asm_wasm.s | ||
deepequal.go | ||
example_test.go | ||
export_test.go | ||
makefunc.go | ||
set_test.go | ||
swapper.go | ||
tostring_test.go | ||
type.go | ||
value.go |