mirror of
https://github.com/golang/go
synced 2024-11-26 22:21:27 -07:00
606019cb4b
This information is redundant with the position information already provided. Also, no other -m diagnostics print out function name. While here, report parameter leak diagnostics against the parameter declaration position rather than the function, and use Warnl for "moved to heap" messages. Test cases updated programmatically by removing the first word from every "no match for" error emitted by run.go: go run run.go |& \ sed -E -n 's/^(.*):(.*): no match for `([^ ]* (.*))` in:$/\1!\2!\3!\4/p' | \ while IFS='!' read -r fn line before after; do before=$(echo "$before" | sed 's/[.[\*^$()+?{|]/\\&/g') after=$(echo "$after" | sed -E 's/(\&|\\)/\\&/g') fn=$(find . -name "${fn}" | head -1) sed -i -E -e "${line}s/\"${before}\"/\"${after}\"/" "${fn}" done Passes toolstash-check. Change-Id: I6e02486b1409e4a8dbb2b9b816d22095835426b5 Reviewed-on: https://go-review.googlesource.com/c/go/+/195040 Run-TryBot: Matthew Dempsky <mdempsky@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Cherry Zhang <cherryyz@google.com>
161 lines
3.4 KiB
Go
161 lines
3.4 KiB
Go
// errorcheck -0 -m -l
|
|
|
|
// Copyright 2015 The Go Authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style
|
|
// license that can be found in the LICENSE file.
|
|
|
|
// Test escape analysis when assigning to indirections.
|
|
|
|
package escape
|
|
|
|
var sink interface{}
|
|
|
|
type ConstPtr struct {
|
|
p *int
|
|
c ConstPtr2
|
|
x **ConstPtr
|
|
}
|
|
|
|
type ConstPtr2 struct {
|
|
p *int
|
|
i int
|
|
}
|
|
|
|
func constptr0() {
|
|
i := 0 // ERROR "moved to heap: i"
|
|
x := &ConstPtr{} // ERROR "&ConstPtr literal does not escape"
|
|
// BAD: i should not escape here
|
|
x.p = &i
|
|
_ = x
|
|
}
|
|
|
|
func constptr01() *ConstPtr {
|
|
i := 0 // ERROR "moved to heap: i"
|
|
x := &ConstPtr{} // ERROR "&ConstPtr literal escapes to heap"
|
|
x.p = &i
|
|
return x
|
|
}
|
|
|
|
func constptr02() ConstPtr {
|
|
i := 0 // ERROR "moved to heap: i"
|
|
x := &ConstPtr{} // ERROR "&ConstPtr literal does not escape"
|
|
x.p = &i
|
|
return *x
|
|
}
|
|
|
|
func constptr03() **ConstPtr {
|
|
i := 0 // ERROR "moved to heap: i"
|
|
x := &ConstPtr{} // ERROR "&ConstPtr literal escapes to heap" "moved to heap: x"
|
|
x.p = &i
|
|
return &x
|
|
}
|
|
|
|
func constptr1() {
|
|
i := 0 // ERROR "moved to heap: i"
|
|
x := &ConstPtr{} // ERROR "&ConstPtr literal escapes to heap"
|
|
x.p = &i
|
|
sink = x
|
|
}
|
|
|
|
func constptr2() {
|
|
i := 0 // ERROR "moved to heap: i"
|
|
x := &ConstPtr{} // ERROR "&ConstPtr literal does not escape"
|
|
x.p = &i
|
|
sink = *x // ERROR "\*x escapes to heap"
|
|
}
|
|
|
|
func constptr4() *ConstPtr {
|
|
p := new(ConstPtr) // ERROR "new\(ConstPtr\) escapes to heap"
|
|
*p = *&ConstPtr{} // ERROR "&ConstPtr literal does not escape"
|
|
return p
|
|
}
|
|
|
|
func constptr5() *ConstPtr {
|
|
p := new(ConstPtr) // ERROR "new\(ConstPtr\) escapes to heap"
|
|
p1 := &ConstPtr{} // ERROR "&ConstPtr literal does not escape"
|
|
*p = *p1
|
|
return p
|
|
}
|
|
|
|
// BAD: p should not escape here
|
|
func constptr6(p *ConstPtr) { // ERROR "leaking param content: p"
|
|
p1 := &ConstPtr{} // ERROR "&ConstPtr literal does not escape"
|
|
*p1 = *p
|
|
_ = p1
|
|
}
|
|
|
|
func constptr7() **ConstPtr {
|
|
p := new(ConstPtr) // ERROR "new\(ConstPtr\) escapes to heap" "moved to heap: p"
|
|
var tmp ConstPtr2
|
|
p1 := &tmp
|
|
p.c = *p1
|
|
return &p
|
|
}
|
|
|
|
func constptr8() *ConstPtr {
|
|
p := new(ConstPtr) // ERROR "new\(ConstPtr\) escapes to heap"
|
|
var tmp ConstPtr2
|
|
p.c = *&tmp
|
|
return p
|
|
}
|
|
|
|
func constptr9() ConstPtr {
|
|
p := new(ConstPtr) // ERROR "new\(ConstPtr\) does not escape"
|
|
var p1 ConstPtr2
|
|
i := 0 // ERROR "moved to heap: i"
|
|
p1.p = &i
|
|
p.c = p1
|
|
return *p
|
|
}
|
|
|
|
func constptr10() ConstPtr {
|
|
x := &ConstPtr{} // ERROR "moved to heap: x" "&ConstPtr literal escapes to heap"
|
|
i := 0 // ERROR "moved to heap: i"
|
|
var p *ConstPtr
|
|
p = &ConstPtr{p: &i, x: &x} // ERROR "&ConstPtr literal does not escape"
|
|
var pp **ConstPtr
|
|
pp = &p
|
|
return **pp
|
|
}
|
|
|
|
func constptr11() *ConstPtr {
|
|
i := 0 // ERROR "moved to heap: i"
|
|
p := new(ConstPtr) // ERROR "new\(ConstPtr\) escapes to heap"
|
|
p1 := &ConstPtr{} // ERROR "&ConstPtr literal does not escape"
|
|
p1.p = &i
|
|
*p = *p1
|
|
return p
|
|
}
|
|
|
|
func foo(p **int) { // ERROR "p does not escape"
|
|
i := 0 // ERROR "moved to heap: i"
|
|
y := p
|
|
*y = &i
|
|
}
|
|
|
|
func foo1(p *int) { // ERROR "p does not escape"
|
|
i := 0 // ERROR "moved to heap: i"
|
|
y := &p
|
|
*y = &i
|
|
}
|
|
|
|
func foo2() {
|
|
type Z struct {
|
|
f **int
|
|
}
|
|
x := new(int) // ERROR "moved to heap: x" "new\(int\) escapes to heap"
|
|
sink = &x
|
|
var z Z
|
|
z.f = &x
|
|
p := z.f
|
|
i := 0 // ERROR "moved to heap: i"
|
|
*p = &i
|
|
}
|
|
|
|
var global *byte
|
|
|
|
func f() {
|
|
var x byte // ERROR "moved to heap: x"
|
|
global = &*&x
|
|
}
|