77296e3645
When writing the set of commands excuted for go build -x, $WORK is substituted for the work directory in all the commnands. But this includes the cat <<EOF commands used to create a file with the given contents. While we can expect the shell to substitute $WORK properly, commands that read input files, such as importcfgs won't do that substitution. This is necessary to fix the build_dash_x script test for CL 432535 because it removes .a files from the traditional stdlib install locations. The test can pass even with importcfg packagefiles in $WORK because all transitive imports are in the stdlib, and the compiler can fall back to finding stdlib .a files in their traditional places, but once they're gone the packagefile paths in $WORK will have paths that contain the string $WORK, and os.Open will fail to open them for reading. And since the fallback is gone the test will fail. For #47257 Change-Id: I5db0066de6ed3ccf97927a78ce0939e3eb14aebe Reviewed-on: https://go-review.googlesource.com/c/go/+/446116 TryBot-Result: Gopher Robot <gobot@golang.org> Run-TryBot: Michael Matloob <matloob@golang.org> Reviewed-by: Bryan Mills <bcmills@google.com> Reviewed-by: Michael Matloob <matloob@golang.org> |
||
---|---|---|
.github | ||
api | ||
doc | ||
lib/time | ||
misc | ||
src | ||
test | ||
.gitattributes | ||
.gitignore | ||
codereview.cfg | ||
CONTRIBUTING.md | ||
LICENSE | ||
PATENTS | ||
README.md | ||
SECURITY.md |
The Go Programming Language
Go is an open source programming language that makes it easy to build simple, reliable, and efficient software.
Gopher image by Renee French, licensed under Creative Commons 3.0 Attributions license.
Our canonical Git repository is located at https://go.googlesource.com/go. There is a mirror of the repository at https://github.com/golang/go.
Unless otherwise noted, the Go source files are distributed under the BSD-style license found in the LICENSE file.
Download and Install
Binary Distributions
Official binary distributions are available at https://go.dev/dl/.
After downloading a binary release, visit https://go.dev/doc/install for installation instructions.
Install From Source
If a binary distribution is not available for your combination of operating system and architecture, visit https://go.dev/doc/install/source for source installation instructions.
Contributing
Go is the work of thousands of contributors. We appreciate your help!
To contribute, please read the contribution guidelines at https://go.dev/doc/contribute.
Note that the Go project uses the issue tracker for bug reports and proposals only. See https://go.dev/wiki/Questions for a list of places to ask questions about the Go language.