mirror of
https://github.com/golang/go
synced 2024-11-19 22:04:44 -07:00
7c7081f514
sync/atomic.StorePointer (which is implemented in runtime/atomic_pointer.go) writes the pointer twice (through two completely different code paths, no less). Fix it to only write once. Change-Id: Id3b2aef9aa9081c2cf096833e001b93d3dd1f5da Reviewed-on: https://go-review.googlesource.com/21999 Run-TryBot: Austin Clements <austin@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org> Reviewed-by: Michael Matloob <matloob@golang.org> Reviewed-by: Rick Hudson <rlh@golang.org>
73 lines
2.8 KiB
Go
73 lines
2.8 KiB
Go
// Copyright 2009 The Go Authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style
|
|
// license that can be found in the LICENSE file.
|
|
|
|
package runtime
|
|
|
|
import (
|
|
"runtime/internal/atomic"
|
|
"unsafe"
|
|
)
|
|
|
|
// These functions cannot have go:noescape annotations,
|
|
// because while ptr does not escape, new does.
|
|
// If new is marked as not escaping, the compiler will make incorrect
|
|
// escape analysis decisions about the pointer value being stored.
|
|
// Instead, these are wrappers around the actual atomics (casp1 and so on)
|
|
// that use noescape to convey which arguments do not escape.
|
|
|
|
// atomicstorep performs *ptr = new atomically and invokes a write barrier.
|
|
//
|
|
//go:nosplit
|
|
func atomicstorep(ptr unsafe.Pointer, new unsafe.Pointer) {
|
|
atomic.StorepNoWB(noescape(ptr), new)
|
|
writebarrierptr_nostore((*uintptr)(ptr), uintptr(new))
|
|
}
|
|
|
|
//go:nosplit
|
|
func casp(ptr *unsafe.Pointer, old, new unsafe.Pointer) bool {
|
|
if !atomic.Casp1((*unsafe.Pointer)(noescape(unsafe.Pointer(ptr))), noescape(old), new) {
|
|
return false
|
|
}
|
|
writebarrierptr_nostore((*uintptr)(unsafe.Pointer(ptr)), uintptr(new))
|
|
return true
|
|
}
|
|
|
|
// Like above, but implement in terms of sync/atomic's uintptr operations.
|
|
// We cannot just call the runtime routines, because the race detector expects
|
|
// to be able to intercept the sync/atomic forms but not the runtime forms.
|
|
|
|
//go:linkname sync_atomic_StoreUintptr sync/atomic.StoreUintptr
|
|
func sync_atomic_StoreUintptr(ptr *uintptr, new uintptr)
|
|
|
|
//go:linkname sync_atomic_StorePointer sync/atomic.StorePointer
|
|
//go:nosplit
|
|
func sync_atomic_StorePointer(ptr *unsafe.Pointer, new unsafe.Pointer) {
|
|
sync_atomic_StoreUintptr((*uintptr)(unsafe.Pointer(ptr)), uintptr(new))
|
|
writebarrierptr_nostore((*uintptr)(unsafe.Pointer(ptr)), uintptr(new))
|
|
}
|
|
|
|
//go:linkname sync_atomic_SwapUintptr sync/atomic.SwapUintptr
|
|
func sync_atomic_SwapUintptr(ptr *uintptr, new uintptr) uintptr
|
|
|
|
//go:linkname sync_atomic_SwapPointer sync/atomic.SwapPointer
|
|
//go:nosplit
|
|
func sync_atomic_SwapPointer(ptr *unsafe.Pointer, new unsafe.Pointer) unsafe.Pointer {
|
|
old := unsafe.Pointer(sync_atomic_SwapUintptr((*uintptr)(noescape(unsafe.Pointer(ptr))), uintptr(new)))
|
|
writebarrierptr_nostore((*uintptr)(unsafe.Pointer(ptr)), uintptr(new))
|
|
return old
|
|
}
|
|
|
|
//go:linkname sync_atomic_CompareAndSwapUintptr sync/atomic.CompareAndSwapUintptr
|
|
func sync_atomic_CompareAndSwapUintptr(ptr *uintptr, old, new uintptr) bool
|
|
|
|
//go:linkname sync_atomic_CompareAndSwapPointer sync/atomic.CompareAndSwapPointer
|
|
//go:nosplit
|
|
func sync_atomic_CompareAndSwapPointer(ptr *unsafe.Pointer, old, new unsafe.Pointer) bool {
|
|
if !sync_atomic_CompareAndSwapUintptr((*uintptr)(noescape(unsafe.Pointer(ptr))), uintptr(old), uintptr(new)) {
|
|
return false
|
|
}
|
|
writebarrierptr_nostore((*uintptr)(unsafe.Pointer(ptr)), uintptr(new))
|
|
return true
|
|
}
|