1
0
mirror of https://github.com/golang/go synced 2024-11-18 23:24:39 -07:00
go/internal/lsp/cache
Heschi Kreinick f520afa52e internal/lsp: remove Ignore feature
Ignore ignored the builtin package and files that start with _. The
latter should already be ignored by "go list". The former seems
like too much effort to me. People shouldn't edit random parts of the
stdlib, and ignoring changes to (e.g.) the Error interface seems like
the least of the trouble they can get themselves into.

Remove it for now. If we get complains I'll re-add it, probably by
rejecting the write entirely somewhere.

We incidentally relied on this in the identifier functions; change those
to treat the builtin package slightly more specially.

Change-Id: I005b02a66b1a987c50a3074d53a2d28ff07d3324
Reviewed-on: https://go-review.googlesource.com/c/tools/+/237597
Run-TryBot: Heschi Kreinick <heschi@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Rebecca Stambler <rstambler@golang.org>
2020-06-11 22:55:14 +00:00
..
analysis.go internal/lsp: fix caching issue with duplicate handles 2020-05-07 19:23:25 +00:00
cache.go internal/lsp: read files eagerly 2020-06-11 22:11:59 +00:00
check.go internal/lsp: read files eagerly 2020-06-11 22:11:59 +00:00
error_test.go internal/lsp: refactor error handling code in type-checking 2019-10-21 18:57:46 +00:00
errors.go internal/lsp: read files eagerly 2020-06-11 22:11:59 +00:00
keys.go internal/lsp: decouple client and server debug 2020-06-11 13:49:48 +00:00
load.go internal/lsp/cache: vendored packages are not workspace packages 2020-06-11 22:31:50 +00:00
mod.go internal/lsp: read files eagerly 2020-06-11 22:11:59 +00:00
os_darwin.go internal/lsp: add a mutex around the view's options 2020-04-02 16:41:49 +00:00
os_windows.go internal/lsp/cache: validate workspace path case 2020-03-27 19:55:53 +00:00
parse.go internal/lsp: read files eagerly 2020-06-11 22:11:59 +00:00
pkg.go internal/lsp: read files eagerly 2020-06-11 22:11:59 +00:00
session.go internal/lsp: remove Ignore feature 2020-06-11 22:55:14 +00:00
snapshot.go internal/lsp: read files eagerly 2020-06-11 22:11:59 +00:00
view_test.go internal/lsp/cache: validate workspace path case 2020-03-27 19:55:53 +00:00
view.go internal/lsp: remove Ignore feature 2020-06-11 22:55:14 +00:00