1
0
mirror of https://github.com/golang/go synced 2024-11-18 16:54:43 -07:00
go/internal/lsp
Rebecca Stambler 73cd2cc3b5 internal/lsp: don't run analyses on the entire view
Running staticcheck on the entire workspace causes a slowdown, and most
likely users don't want to see staticcheck reports for every
subdirectory of their workspace. Only run staticcheck on open files.

Also, fixed a staticcheck warning that showed up along the way. Filed
golang/go#35718 to remind ourselves to fix all of the staticcheck warnings
that showed up when we ran gopls with staticcheck on x/tools.

Finally, made sure that we don't send empty diagnostics when diagnosing
the snapshot on start-up, as that is not necessary.

Change-Id: Ic51d1abfc80b1b53397057f06a4cfd7e2dc930f9
Reviewed-on: https://go-review.googlesource.com/c/tools/+/208098
Run-TryBot: Rebecca Stambler <rstambler@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Ian Cottrell <iancottrell@google.com>
2019-11-25 22:48:44 +00:00
..
browser internal/lsp: add version and bug commands 2019-05-11 04:16:02 +00:00
cache internal/lsp: don't run analyses on the entire view 2019-11-25 22:48:44 +00:00
cmd internal/lsp: don't run analyses on the entire view 2019-11-25 22:48:44 +00:00
debug internal/lsp: fix the debug info pages 2019-11-04 23:16:26 +00:00
diff internal/lsp: fix unified diffs of edits at the end of a file 2019-10-11 16:38:14 +00:00
fuzzy internal/lsp: fix fuzzy matcher inconsistency 2019-10-22 21:05:28 +00:00
protocol internal/lsp: make Range a pointer in Change events 2019-11-20 19:02:09 +00:00
snippet all: fix broken links to LSP specification 2019-10-02 18:32:53 +00:00
source internal/lsp: don't run analyses on the entire view 2019-11-25 22:48:44 +00:00
telemetry internal/lsp: call load in (*session).NewView 2019-11-07 23:34:59 +00:00
testdata internal/lsp/tests: skip cgo tests when not supported 2019-11-25 21:54:41 +00:00
tests internal/lsp/tests: skip cgo tests when not supported 2019-11-25 21:54:41 +00:00
code_action.go internal/lsp: don't run analyses on the entire view 2019-11-25 22:48:44 +00:00
command.go internal/lsp: fix panic in bestView 2019-11-16 21:44:31 +00:00
completion_test.go internal/lsp: fix variadic interface completion ranking 2019-11-18 05:14:29 +00:00
completion.go internal/lsp: improve completion ordering workaround 2019-11-22 18:27:03 +00:00
definition.go internal/lsp: reorganize and refactor code 2019-11-21 02:33:28 +00:00
diagnostics.go internal/lsp: don't run analyses on the entire view 2019-11-25 22:48:44 +00:00
folding_range.go internal/lsp: reorganize and refactor code 2019-11-21 02:33:28 +00:00
format.go internal/lsp: reorganize and refactor code 2019-11-21 02:33:28 +00:00
general.go internal/lsp: don't run analyses on the entire view 2019-11-25 22:48:44 +00:00
highlight.go internal/lsp: reorganize and refactor code 2019-11-21 02:33:28 +00:00
hover.go internal/lsp: reorganize and refactor code 2019-11-21 02:33:28 +00:00
implementation.go internal/lsp: reorganize and refactor code 2019-11-21 02:33:28 +00:00
link.go internal/lsp: fix panic in bestView 2019-11-16 21:44:31 +00:00
lsp_test.go internal/lsp: don't run analyses on the entire view 2019-11-25 22:48:44 +00:00
references.go internal/lsp: reorganize and refactor code 2019-11-21 02:33:28 +00:00
rename.go internal/lsp: reorganize and refactor code 2019-11-21 02:33:28 +00:00
reset_golden.sh internal/lsp: fix regeneration of golden files 2019-09-25 13:16:59 +00:00
server.go internal/lsp: don't run analyses on the entire view 2019-11-25 22:48:44 +00:00
signature_help.go internal/lsp: reorganize and refactor code 2019-11-21 02:33:28 +00:00
symbols.go internal/lsp: reorganize and refactor code 2019-11-21 02:33:28 +00:00
text_synchronization.go internal/lsp: don't run analyses on the entire view 2019-11-25 22:48:44 +00:00
watched_files.go internal/lsp: don't run analyses on the entire view 2019-11-25 22:48:44 +00:00
workspace.go internal/lsp: set version correctly after textDocument/didOpen 2019-11-25 19:35:51 +00:00