mirror of
https://github.com/golang/go
synced 2024-10-04 09:21:21 -06:00
821b54921a
The case fixed by this change happens when, in func (pr partReader) Read, the Peek happens to read so that peek looks like: "somedata\r\n--Boundary\r" peekBufferSeparatorIndex was returning (-1, false) because it didn't find the trailing '\n'. This was wrong because: 1) It didn't match the documentation: as "\r\n--Boundary" was found, it should return the index of that pattern, not -1. 2) It lead to an nCopy cut such as: "somedata\r| |\n--Boundary\r" instead of "somedata| |\r\n--Boundary\r" which made the subsequent Read miss the boundary, and eventually end with a "return 0, io.ErrUnexpectedEOF" case, as reported in: https://github.com/camlistore/camlistore/issues/642 Change-Id: I1ba78a741bc0c7719e160add9cca932d10f8a615 Reviewed-on: https://go-review.googlesource.com/15269 Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org> Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org> |
||
|---|---|---|
| .. | ||
| multipart | ||
| quotedprintable | ||
| testdata | ||
| encodedword_test.go | ||
| encodedword.go | ||
| example_test.go | ||
| grammar.go | ||
| mediatype_test.go | ||
| mediatype.go | ||
| type_dragonfly.go | ||
| type_freebsd.go | ||
| type_openbsd.go | ||
| type_plan9.go | ||
| type_test.go | ||
| type_unix.go | ||
| type_windows.go | ||
| type.go | ||