734cb8be0a
Some logic was missing in the merge from dev.go2go to deal with untyped conversion of generic types. Part of this was due to the complexity of the merge, as untyped conversion had been refactored on master. Rather than back out the refactoring of untyped conversion, in this CL I have decided to take it one step further. It was always problematic that isRepresentable and canConvertUntyped mutated their arguments. In retrospect the refactoring was perhaps too conservative. This CL performs the following refactoring: + Replace 'isRepresentable' with 'representation': a Checker method produces the rounded representation of an untyped constant operand as a target type. + Make some functions return error codes rather than errors, and factor out the construction of the error message for invalid conversion. This avoided some indirect code. + Replace implicitType with implicitTypeAndValue, and have it handle the case of a constant basic operand, returning the rounded value. + Eliminate canConvertUntyped, lifting the logic to update expr types and values to the two callers. + Add handling for Sum types in implicitTypeAndValue. Here, the decision was made to depart from dev.go2go (and types2), and produce a Sum type as output. This seemed most correct on first principles, and tests still passed (though some logic for recording types had to be updated to allow for Sum types). Change-Id: Ic93901f69e6671b83b14ee2bf185a4ed767e31ee Reviewed-on: https://go-review.googlesource.com/c/go/+/284256 Run-TryBot: Robert Findley <rfindley@google.com> TryBot-Result: Go Bot <gobot@golang.org> Reviewed-by: Robert Griesemer <gri@golang.org> Trust: Robert Griesemer <gri@golang.org> Trust: Robert Findley <rfindley@google.com> |
||
|---|---|---|
| .github | ||
| api | ||
| doc | ||
| lib/time | ||
| misc | ||
| src | ||
| test | ||
| .gitattributes | ||
| .gitignore | ||
| AUTHORS | ||
| codereview.cfg | ||
| CONTRIBUTING.md | ||
| CONTRIBUTORS | ||
| favicon.ico | ||
| LICENSE | ||
| PATENTS | ||
| README.md | ||
| robots.txt | ||
| SECURITY.md | ||
The Go Programming Language
Go is an open source programming language that makes it easy to build simple, reliable, and efficient software.
Gopher image by Renee French, licensed under Creative Commons 3.0 Attributions license.
Our canonical Git repository is located at https://go.googlesource.com/go. There is a mirror of the repository at https://github.com/golang/go.
Unless otherwise noted, the Go source files are distributed under the BSD-style license found in the LICENSE file.
Download and Install
Binary Distributions
Official binary distributions are available at https://golang.org/dl/.
After downloading a binary release, visit https://golang.org/doc/install or load doc/install.html in your web browser for installation instructions.
Install From Source
If a binary distribution is not available for your combination of operating system and architecture, visit https://golang.org/doc/install/source or load doc/install-source.html in your web browser for source installation instructions.
Contributing
Go is the work of thousands of contributors. We appreciate your help!
To contribute, please read the contribution guidelines: https://golang.org/doc/contribute.html
Note that the Go project uses the issue tracker for bug reports and proposals only. See https://golang.org/wiki/Questions for a list of places to ask questions about the Go language.