7348773640
This change cleans up the ordering interface in several ways. First, it resolves a TODO about using a proper queue of events for extra events produced while performing ordering. This will be necessary for a follow-up change to handle coroutine switch events. Next, it simplifies the ordering.advance method's signature by not returning a schedCtx. Instead, ordering.advance will take responsibility for constructing the final Event instead of the caller, and places it on its own internal queue (in addition to any other Events generated). The caller is then responsible for taking events off of the queue with a new method Next. Finally, hand-in-hand with the signature change, the implementation of ordering.advance no longer forces each switch case to return but instead has them converge past the switch. This has two effects. One is that we eliminate the deferred call to update the M state. Using a defer here is technically incorrect, because we might end up changing the M state even if we don't advance the event! We got lucky here that curCtx == newCtx in all such cases, but there may have been a subtle bug lurking here. Unfortunately because of the queue's semantics however, we can't actually avoid pushing into the queue at every possible successful exit out of the switch. Hopefully this can become less error-prone in the future by splitting up the switch into a dispatch of different functions, instead of everything living in one giant function. This cleanup will happen in a follow-up change. Change-Id: Ifebbbf14e8ed5c08be5c1b0fadc2e5df3915c656 Reviewed-on: https://go-review.googlesource.com/c/go/+/565936 LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Michael Pratt <mpratt@google.com> Auto-Submit: Michael Knyszek <mknyszek@google.com> |
||
|---|---|---|
| .github | ||
| api | ||
| doc | ||
| lib/time | ||
| misc | ||
| src | ||
| test | ||
| .gitattributes | ||
| .gitignore | ||
| codereview.cfg | ||
| CONTRIBUTING.md | ||
| go.env | ||
| LICENSE | ||
| PATENTS | ||
| README.md | ||
| SECURITY.md | ||
The Go Programming Language
Go is an open source programming language that makes it easy to build simple, reliable, and efficient software.
Gopher image by Renee French, licensed under Creative Commons 4.0 Attributions license.
Our canonical Git repository is located at https://go.googlesource.com/go. There is a mirror of the repository at https://github.com/golang/go.
Unless otherwise noted, the Go source files are distributed under the BSD-style license found in the LICENSE file.
Download and Install
Binary Distributions
Official binary distributions are available at https://go.dev/dl/.
After downloading a binary release, visit https://go.dev/doc/install for installation instructions.
Install From Source
If a binary distribution is not available for your combination of operating system and architecture, visit https://go.dev/doc/install/source for source installation instructions.
Contributing
Go is the work of thousands of contributors. We appreciate your help!
To contribute, please read the contribution guidelines at https://go.dev/doc/contribute.
Note that the Go project uses the issue tracker for bug reports and proposals only. See https://go.dev/wiki/Questions for a list of places to ask questions about the Go language.