73269b8e75
The commutative rule generator has an optimization where given (Add x y) with no other uses of x and y in the matching rule, it doesn't generate the commutative match (Add y x). However, if there is also a condition referring to x or y, such as (Add x y) && isFoo(x), then we should generate the commutative rule. This change parses the condition, extracts all idents, and takes them into consideration. This doesn't yield any new optimizations now. However, it is the right thing to do; otherwise we'll have to track it down and fix it again later. It is also expensive now, in terms of additional generated code. However, it will be much, much less expensive soon, once our generated code for commutative ops gets smaller. Change-Id: I52c2016c884bbc7789bf8dfe9b9c56061bc028ad Reviewed-on: https://go-review.googlesource.com/c/go/+/213702 Run-TryBot: Josh Bleecher Snyder <josharian@gmail.com> Reviewed-by: Keith Randall <khr@golang.org> |
||
|---|---|---|
| .github | ||
| api | ||
| doc | ||
| lib/time | ||
| misc | ||
| src | ||
| test | ||
| .gitattributes | ||
| .gitignore | ||
| AUTHORS | ||
| CONTRIBUTING.md | ||
| CONTRIBUTORS | ||
| favicon.ico | ||
| LICENSE | ||
| PATENTS | ||
| README.md | ||
| robots.txt | ||
| SECURITY.md | ||
The Go Programming Language
Go is an open source programming language that makes it easy to build simple, reliable, and efficient software.
Gopher image by Renee French, licensed under Creative Commons 3.0 Attributions license.
Our canonical Git repository is located at https://go.googlesource.com/go. There is a mirror of the repository at https://github.com/golang/go.
Unless otherwise noted, the Go source files are distributed under the BSD-style license found in the LICENSE file.
Download and Install
Binary Distributions
Official binary distributions are available at https://golang.org/dl/.
After downloading a binary release, visit https://golang.org/doc/install or load doc/install.html in your web browser for installation instructions.
Install From Source
If a binary distribution is not available for your combination of operating system and architecture, visit https://golang.org/doc/install/source or load doc/install-source.html in your web browser for source installation instructions.
Contributing
Go is the work of thousands of contributors. We appreciate your help!
To contribute, please read the contribution guidelines: https://golang.org/doc/contribute.html
Note that the Go project uses the issue tracker for bug reports and proposals only. See https://golang.org/wiki/Questions for a list of places to ask questions about the Go language.