mirror of
https://github.com/golang/go
synced 2024-10-01 01:48:32 -06:00
46bd65c853
This change attempts to fix a concurrency error that would cause textDocument/CodeLens, textDocument/Formatting, textDocument/DocumentLink, and textDocument/Hover from failing on go.mod files. The issue was that the go command would return a potential concurrency error since the ModHandle and the ModTidyHandle are both using the temporary go.mod file. Updates golang/go#37824 Change-Id: I6cd63c1f75817c7308e033aec473966536a2a3bd Reviewed-on: https://go-review.googlesource.com/c/tools/+/224917 Reviewed-by: Heschi Kreinick <heschi@google.com> Run-TryBot: Rebecca Stambler <rstambler@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org>
88 lines
2.7 KiB
Go
88 lines
2.7 KiB
Go
// Copyright 2020 The Go Authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style
|
|
// license that can be found in the LICENSE file.
|
|
|
|
package lsp
|
|
|
|
import (
|
|
"context"
|
|
"strings"
|
|
|
|
"golang.org/x/tools/internal/gocommand"
|
|
"golang.org/x/tools/internal/lsp/protocol"
|
|
"golang.org/x/tools/internal/lsp/source"
|
|
"golang.org/x/tools/internal/packagesinternal"
|
|
"golang.org/x/tools/internal/xcontext"
|
|
errors "golang.org/x/xerrors"
|
|
)
|
|
|
|
func (s *Server) executeCommand(ctx context.Context, params *protocol.ExecuteCommandParams) (interface{}, error) {
|
|
switch params.Command {
|
|
case "generate":
|
|
dir, recursive, err := getGenerateRequest(params.Arguments)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
go s.runGenerate(xcontext.Detach(ctx), dir, recursive)
|
|
case "tidy":
|
|
if len(params.Arguments) == 0 || len(params.Arguments) > 1 {
|
|
return nil, errors.Errorf("expected one file URI for call to `go mod tidy`, got %v", params.Arguments)
|
|
}
|
|
uri := protocol.DocumentURI(params.Arguments[0].(string))
|
|
snapshot, _, ok, err := s.beginFileRequest(uri, source.Mod)
|
|
if !ok {
|
|
return nil, err
|
|
}
|
|
cfg := snapshot.Config(ctx)
|
|
// Run go.mod tidy on the view.
|
|
inv := gocommand.Invocation{
|
|
Verb: "mod",
|
|
Args: []string{"tidy"},
|
|
Env: cfg.Env,
|
|
WorkingDir: snapshot.View().Folder().Filename(),
|
|
}
|
|
gocmdRunner := packagesinternal.GetGoCmdRunner(cfg)
|
|
if _, err := gocmdRunner.Run(ctx, inv); err != nil {
|
|
return nil, err
|
|
}
|
|
case "upgrade.dependency":
|
|
if len(params.Arguments) < 2 {
|
|
return nil, errors.Errorf("expected one file URI and one dependency for call to `go get`, got %v", params.Arguments)
|
|
}
|
|
uri := protocol.DocumentURI(params.Arguments[0].(string))
|
|
deps := params.Arguments[1].(string)
|
|
snapshot, _, ok, err := s.beginFileRequest(uri, source.UnknownKind)
|
|
if !ok {
|
|
return nil, err
|
|
}
|
|
cfg := snapshot.Config(ctx)
|
|
// Run "go get" on the dependency to upgrade it to the latest version.
|
|
inv := gocommand.Invocation{
|
|
Verb: "get",
|
|
Args: strings.Split(deps, " "),
|
|
Env: cfg.Env,
|
|
WorkingDir: snapshot.View().Folder().Filename(),
|
|
}
|
|
gocmdRunner := packagesinternal.GetGoCmdRunner(cfg)
|
|
if _, err := gocmdRunner.Run(ctx, inv); err != nil {
|
|
return nil, err
|
|
}
|
|
}
|
|
return nil, nil
|
|
}
|
|
|
|
func getGenerateRequest(args []interface{}) (string, bool, error) {
|
|
if len(args) != 2 {
|
|
return "", false, errors.Errorf("expected exactly 2 arguments but got %d", len(args))
|
|
}
|
|
dir, ok := args[0].(string)
|
|
if !ok {
|
|
return "", false, errors.Errorf("expected dir to be a string value but got %T", args[0])
|
|
}
|
|
recursive, ok := args[1].(bool)
|
|
if !ok {
|
|
return "", false, errors.Errorf("expected recursive to be a boolean but got %T", args[1])
|
|
}
|
|
return dir, recursive, nil
|
|
}
|