mirror of
https://github.com/golang/go
synced 2024-09-30 20:18:33 -06:00
7283e08cbf
Normally, the caller to runtime.entersyscall() must not return before calling runtime.exitsyscall(), lest g->syscallsp become a dangling pointer. runtime.cgocallbackg() violates this constraint. To work around this, save g->syscallsp and g->syscallpc around cgo->Go callbacks, then restore them after calling runtime.entersyscall(), which restores the syscall stack frame pointer saved by cgocall. This allows the GC to correctly trace a goroutine that is currently returning from a Go->cgo->Go chain. This also adds a check to proc.c that panics if g->syscallsp is clearly invalid. It is not 100% foolproof, as it will not catch a case where the stack was popped then pushed back beyond g->syscallsp, but it does catch the present cgo issue and makes existing tests fail without the bugfix. Fixes #7978. LGTM=dvyukov, rsc R=golang-codereviews, dvyukov, minux, bradfitz, iant, gobot, rsc CC=golang-codereviews, rsc https://golang.org/cl/131910043
62 lines
3.2 KiB
Go
62 lines
3.2 KiB
Go
// Copyright 2011 The Go Authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style
|
|
// license that can be found in the LICENSE file.
|
|
|
|
package cgotest
|
|
|
|
import "testing"
|
|
|
|
// The actual test functions are in non-_test.go files
|
|
// so that they can use cgo (import "C").
|
|
// These wrappers are here for gotest to find.
|
|
|
|
func TestAlign(t *testing.T) { testAlign(t) }
|
|
func TestConst(t *testing.T) { testConst(t) }
|
|
func TestEnum(t *testing.T) { testEnum(t) }
|
|
func TestAtol(t *testing.T) { testAtol(t) }
|
|
func TestErrno(t *testing.T) { testErrno(t) }
|
|
func TestMultipleAssign(t *testing.T) { testMultipleAssign(t) }
|
|
func TestUnsignedInt(t *testing.T) { testUnsignedInt(t) }
|
|
func TestCallback(t *testing.T) { testCallback(t) }
|
|
func TestCallbackGC(t *testing.T) { testCallbackGC(t) }
|
|
func TestCallbackPanic(t *testing.T) { testCallbackPanic(t) }
|
|
func TestCallbackPanicLoop(t *testing.T) { testCallbackPanicLoop(t) }
|
|
func TestCallbackPanicLocked(t *testing.T) { testCallbackPanicLocked(t) }
|
|
func TestPanicFromC(t *testing.T) { testPanicFromC(t) }
|
|
func TestAllocateFromC(t *testing.T) { testAllocateFromC(t) }
|
|
func TestZeroArgCallback(t *testing.T) { testZeroArgCallback(t) }
|
|
func TestBlocking(t *testing.T) { testBlocking(t) }
|
|
func Test1328(t *testing.T) { test1328(t) }
|
|
func TestParallelSleep(t *testing.T) { testParallelSleep(t) }
|
|
func TestSetEnv(t *testing.T) { testSetEnv(t) }
|
|
func TestHelpers(t *testing.T) { testHelpers(t) }
|
|
func TestLibgcc(t *testing.T) { testLibgcc(t) }
|
|
func Test1635(t *testing.T) { test1635(t) }
|
|
func TestPrintf(t *testing.T) { testPrintf(t) }
|
|
func Test4029(t *testing.T) { test4029(t) }
|
|
func TestBoolAlign(t *testing.T) { testBoolAlign(t) }
|
|
func Test3729(t *testing.T) { test3729(t) }
|
|
func Test3775(t *testing.T) { test3775(t) }
|
|
func TestCthread(t *testing.T) { testCthread(t) }
|
|
func TestCallbackCallers(t *testing.T) { testCallbackCallers(t) }
|
|
func Test5227(t *testing.T) { test5227(t) }
|
|
func TestCflags(t *testing.T) { testCflags(t) }
|
|
func Test5337(t *testing.T) { test5337(t) }
|
|
func Test5548(t *testing.T) { test5548(t) }
|
|
func Test5603(t *testing.T) { test5603(t) }
|
|
func Test6833(t *testing.T) { test6833(t) }
|
|
func Test3250(t *testing.T) { test3250(t) }
|
|
func TestCallbackStack(t *testing.T) { testCallbackStack(t) }
|
|
func TestFpVar(t *testing.T) { testFpVar(t) }
|
|
func Test4339(t *testing.T) { test4339(t) }
|
|
func Test6390(t *testing.T) { test6390(t) }
|
|
func Test5986(t *testing.T) { test5986(t) }
|
|
func Test7665(t *testing.T) { test7665(t) }
|
|
func TestNaming(t *testing.T) { testNaming(t) }
|
|
func Test7560(t *testing.T) { test7560(t) }
|
|
func Test5242(t *testing.T) { test5242(t) }
|
|
func Test8092(t *testing.T) { test8092(t) }
|
|
func Test7978(t *testing.T) { test7978(t) }
|
|
|
|
func BenchmarkCgoCall(b *testing.B) { benchCgoCall(b) }
|