mirror of
https://github.com/golang/go
synced 2024-11-23 09:20:05 -07:00
326ea438bb
If any of the LHS expressions of an OAS2FUNC are not identical to the respective function call results, escape analysis mishandles the implicit conversion, causes memory corruption. Instead, we should insert autotmps like we already do for f(g()) calls and return g() statements. Fixes #46725 Change-Id: I71a08da0bf1a03d09a023da5b6f78fb37a4a4690 Reviewed-on: https://go-review.googlesource.com/c/go/+/327651 Trust: Cuong Manh Le <cuong.manhle.vn@gmail.com> Run-TryBot: Cuong Manh Le <cuong.manhle.vn@gmail.com> TryBot-Result: Go Bot <gobot@golang.org> Reviewed-by: Matthew Dempsky <mdempsky@google.com>
68 lines
1.4 KiB
Go
68 lines
1.4 KiB
Go
// errorcheck
|
|
|
|
// Copyright 2009 The Go Authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style
|
|
// license that can be found in the LICENSE file.
|
|
|
|
// Test that incorrect short declarations and redeclarations are detected.
|
|
// Does not compile.
|
|
|
|
package main
|
|
|
|
func f1() int { return 1 }
|
|
func f2() (float32, int) { return 1, 2 }
|
|
func f3() (float32, int, string) { return 1, 2, "3" }
|
|
|
|
func main() {
|
|
{
|
|
// simple redeclaration
|
|
i := f1()
|
|
i := f1() // ERROR "redeclared|no new"
|
|
_ = i
|
|
}
|
|
{
|
|
// change of type for f
|
|
i, f, s := f3()
|
|
f, g, t := f3() // ERROR "redeclared|cannot assign|incompatible|cannot use"
|
|
_, _, _, _, _ = i, f, s, g, t
|
|
}
|
|
{
|
|
// change of type for i
|
|
i, f, s := f3()
|
|
j, i, t := f3() // ERROR "redeclared|cannot assign|incompatible|cannot use"
|
|
_, _, _, _, _ = i, f, s, j, t
|
|
}
|
|
{
|
|
// no new variables
|
|
i, f, s := f3()
|
|
i, f := f2() // ERROR "redeclared|no new"
|
|
_, _, _ = i, f, s
|
|
}
|
|
{
|
|
// multiline no new variables
|
|
i := f1
|
|
i := func() int { // ERROR "redeclared|no new|incompatible"
|
|
return 0
|
|
}
|
|
_ = i
|
|
}
|
|
{
|
|
// single redeclaration
|
|
i, f, s := f3()
|
|
i := 1 // ERROR "redeclared|no new|incompatible"
|
|
_, _, _ = i, f, s
|
|
}
|
|
// double redeclaration
|
|
{
|
|
i, f, s := f3()
|
|
i, f := f2() // ERROR "redeclared|no new"
|
|
_, _, _ = i, f, s
|
|
}
|
|
{
|
|
// triple redeclaration
|
|
i, f, s := f3()
|
|
i, f, s := f3() // ERROR "redeclared|no new"
|
|
_, _, _ = i, f, s
|
|
}
|
|
}
|