mirror of
https://github.com/golang/go
synced 2024-11-18 12:44:49 -07:00
615a52b95b
When T is a scalar, there are no runtime calls required, which makes this a clear win. encoding/binary: WriteInts-8 958ns ± 3% 864ns ± 2% -9.80% (p=0.000 n=15+15) This also considerably shrinks a core fmt routine: Before: "".(*pp).printArg t=1 size=3952 args=0x20 locals=0xf0 After: "".(*pp).printArg t=1 size=2624 args=0x20 locals=0x98 Unfortunately, I find it very hard to get stable numbers out of the fmt benchmarks due to thermal scaling. Change-Id: I1278006b030253bf8e48dc7631d18985cdaa143d Reviewed-on: https://go-review.googlesource.com/26659 Run-TryBot: Josh Bleecher Snyder <josharian@gmail.com> Reviewed-by: Keith Randall <khr@golang.org>
68 lines
1.8 KiB
Go
68 lines
1.8 KiB
Go
// errorcheck -0 -d=typeassert
|
|
|
|
// Copyright 2015 The Go Authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style
|
|
// license that can be found in the LICENSE file.
|
|
|
|
package p
|
|
|
|
func assertptr(x interface{}) *int {
|
|
return x.(*int) // ERROR "type assertion inlined"
|
|
}
|
|
|
|
func assertptr2(x interface{}) (*int, bool) {
|
|
z, ok := x.(*int) // ERROR "type assertion inlined"
|
|
return z, ok
|
|
}
|
|
|
|
func assertfunc(x interface{}) func() {
|
|
return x.(func()) // ERROR "type assertion inlined"
|
|
}
|
|
|
|
func assertfunc2(x interface{}) (func(), bool) {
|
|
z, ok := x.(func()) // ERROR "type assertion inlined"
|
|
return z, ok
|
|
}
|
|
|
|
// TODO(rsc): struct{*int} is stored directly in the interface
|
|
// and should be possible to fetch back out of the interface,
|
|
// but more of the general data movement code needs to
|
|
// realize that before we can inline the assertion.
|
|
|
|
func assertstruct(x interface{}) struct{ *int } {
|
|
return x.(struct{ *int }) // ERROR "type assertion not inlined"
|
|
}
|
|
|
|
func assertstruct2(x interface{}) (struct{ *int }, bool) {
|
|
z, ok := x.(struct{ *int }) // ERROR "type assertion not inlined"
|
|
return z, ok
|
|
}
|
|
|
|
func assertbig(x interface{}) complex128 {
|
|
return x.(complex128) // ERROR "type assertion not inlined"
|
|
}
|
|
|
|
func assertbig2(x interface{}) (complex128, bool) {
|
|
z, ok := x.(complex128) // ERROR "type assertion .scalar result. inlined"
|
|
return z, ok
|
|
}
|
|
|
|
func assertbig2ok(x interface{}) (complex128, bool) {
|
|
_, ok := x.(complex128) // ERROR "type assertion [(]ok only[)] inlined"
|
|
return 0, ok
|
|
}
|
|
|
|
func assertslice(x interface{}) []int {
|
|
return x.([]int) // ERROR "type assertion not inlined"
|
|
}
|
|
|
|
func assertslice2(x interface{}) ([]int, bool) {
|
|
z, ok := x.([]int) // ERROR "type assertion not inlined"
|
|
return z, ok
|
|
}
|
|
|
|
func assertslice2ok(x interface{}) ([]int, bool) {
|
|
_, ok := x.([]int) // ERROR "type assertion [(]ok only[)] inlined"
|
|
return nil, ok
|
|
}
|