Suzy Mueller fc82fb2afd internal/lsp: return error when renaming within an import spec ... Since renaming an identifier within an import spec is not yet supported, return an error when this is encountered. These idents from the import spec have a nil declaration object. Import paths that contain '.' or '/' are caught by the valid identifier check avoiding the crash, but import paths such as "fmt" are not as fmt is a valid identifier. This change checks if i.decl.obj is nil and returns an error if it is to avoid the crash. Fixes golang/go#33768 Change-Id: I4e757b42bedffd648fc821590e4a383826200dc3 Reviewed-on: https://go-review.googlesource.com/c/tools/+/191163 Run-TryBot: Suzy Mueller <suzmue@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Ian Cottrell <iancottrell@google.com>		2019-08-22 00:03:11 +00:00
..
a	internal/lsp: return error when renaming within an import spec	2019-08-22 00:03:11 +00:00
b	internal/lsp: return an error when renaming a builtin	2019-07-09 18:23:51 +00:00
bad	internal/lsp: return rename errors for one package only	2019-08-16 17:04:40 +00:00
testy	internal/lsp: fix bug renaming local vars with test files present	2019-08-15 14:43:58 +00:00