71a6c13164
Restore code to call types.CheckSize() in g.typ(). There are certain cases (involving maps) where we need to do CheckSize here. In general, the old typechecker calls CheckSize() a lot, and we want to eliminate calling it eventually, so should get do types.CheckSize() when we create a new concrete type. However, the test typeparams/cons.go does not work with just calling types.CheckSize() in g.typ() (which is why I disabled the calls originally). The reason is that g.typ() is called recursively within types.go, so it can be called on a partially-created recursive type, which leads to an error in CheckSize(). So, we need to call CheckSize() only on fully-created top-level types. So, I divided typ() into typ() and typ1(), where typ() is now the external entry point, and typ1() is called within types.go. Now, typ() can call CheckSize() safely. I also added in an extra condition - we do not currently need to call CheckSize() on non-fully-instantiated types, since they will not make it to the backend. That could change a bit with dictionaries. Fixes #44895 Change-Id: I783aa7d2999dd882ddbd99a7c19a6ff6ee420102 Reviewed-on: https://go-review.googlesource.com/c/go/+/300989 Run-TryBot: Dan Scales <danscales@google.com> TryBot-Result: Go Bot <gobot@golang.org> Trust: Dan Scales <danscales@google.com> Trust: Robert Griesemer <gri@golang.org> Reviewed-by: Robert Griesemer <gri@golang.org> |
||
|---|---|---|
| .github | ||
| api | ||
| doc | ||
| lib/time | ||
| misc | ||
| src | ||
| test | ||
| .gitattributes | ||
| .gitignore | ||
| AUTHORS | ||
| codereview.cfg | ||
| CONTRIBUTING.md | ||
| CONTRIBUTORS | ||
| favicon.ico | ||
| LICENSE | ||
| PATENTS | ||
| README.md | ||
| robots.txt | ||
| SECURITY.md | ||
The Go Programming Language
Go is an open source programming language that makes it easy to build simple, reliable, and efficient software.
Gopher image by Renee French, licensed under Creative Commons 3.0 Attributions license.
Our canonical Git repository is located at https://go.googlesource.com/go. There is a mirror of the repository at https://github.com/golang/go.
Unless otherwise noted, the Go source files are distributed under the BSD-style license found in the LICENSE file.
Download and Install
Binary Distributions
Official binary distributions are available at https://golang.org/dl/.
After downloading a binary release, visit https://golang.org/doc/install for installation instructions.
Install From Source
If a binary distribution is not available for your combination of operating system and architecture, visit https://golang.org/doc/install/source for source installation instructions.
Contributing
Go is the work of thousands of contributors. We appreciate your help!
To contribute, please read the contribution guidelines at https://golang.org/doc/contribute.html.
Note that the Go project uses the issue tracker for bug reports and proposals only. See https://golang.org/wiki/Questions for a list of places to ask questions about the Go language.