1
0
mirror of https://github.com/golang/go synced 2024-11-18 14:54:40 -07:00
go/gopls/doc
Rob Findley f2c07d7d8e internal/lsp/lsprpc: improvements to daemon logging
The gopls daemon had different default logging behavior than the sidecar
gopls: by default, the daemon was started with -logfile=auto.
Additionally, because most logs are reflected back to the forwarder, the
actual daemon logs have very little (if any) information.

This means that if you simply start gopls with -remote=auto, you'll get
a single logfile named /tmp/gopls-<pid>.log, which is mostly empty. This
is not a delightful experience.

Fix this via several improvements:
 + Log lifecycle events in the Daemon, to give the log a purpose.
 + Give the daemon a new default log location:
   /tmp/gopls-daemon-<pid>.log.
 + Don't pass -logfile=auto to the daemon by default.

Fixes golang/go#40105

Change-Id: I5e91ea98b4968c512bce76a596bbae441f461a66
Reviewed-on: https://go-review.googlesource.com/c/tools/+/241440
Run-TryBot: Robert Findley <rfindley@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Rebecca Stambler <rstambler@golang.org>
2020-07-16 19:33:22 +00:00
..
acme.md
analyzers.md gopls/doc: fix composites analyzer name 2020-06-12 18:47:36 +00:00
atom.md
command-line.md
contributing.md
daemon.md internal/lsp/lsprpc: improvements to daemon logging 2020-07-16 19:33:22 +00:00
design.md
emacs.md gopls/doc: remove company-lsp from emacs.md 2020-05-11 23:25:44 +00:00
faq.md
implementation.md
integrating.md
settings.md gopls/doc: update code lens documentation for the new test lens 2020-05-13 02:27:44 +00:00
status.md gopls/doc: Clear out fixed issues 2020-02-24 23:14:51 +00:00
subl.md
troubleshooting.md gopls/doc/troubleshooting.md: update the gopls output channel name 2020-07-01 15:12:20 +00:00
user.md gopls/doc: document updating to an unstable version 2020-01-25 22:37:03 +00:00
vim.md gopls/docs: adding nvim-lsp option in gopls README file 2020-04-07 19:18:07 +00:00
vscode.md gopls/doc: update vscode-go GitHub link 2020-06-12 15:25:27 +00:00