1
0
mirror of https://github.com/golang/go synced 2024-10-01 03:08:33 -06:00
go/cmd/goimports
Heschi Kreinick 5bcca83a78 internal: rationalize debug logging
In all cases, use a Logf field to configure debug logging. Non-nil means
that logging is enabled through the given function.

Fixes accidental debug spam from goimports, which had a separate Debug
flag that was supposed to guard logging, but wasn't used when creating
the gocommand.Invocation.

Change-Id: I448fa282111db556ac2e49801268d0affc19ae30
Reviewed-on: https://go-review.googlesource.com/c/tools/+/221557
Run-TryBot: Heschi Kreinick <heschi@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Daniel Martí <mvdan@mvdan.cc>
Reviewed-by: Rebecca Stambler <rstambler@golang.org>
2020-03-03 16:59:18 +00:00
..
doc.go cmd/goimports: update Emacs install instructions 2018-11-30 05:20:23 +00:00
goimports_gc.go cmd/goimports: work around lack of runtime/trace in gccgo 2016-08-13 05:07:58 +00:00
goimports_not_gc.go cmd/goimports: work around lack of runtime/trace in gccgo 2016-08-13 05:07:58 +00:00
goimports.go internal: rationalize debug logging 2020-03-03 16:59:18 +00:00