1
0
mirror of https://github.com/golang/go synced 2024-11-05 14:46:11 -07:00
go/gopls/integration
Rob Findley 9497f49d57 gopls/integration: cosmetic/ergonomic updates
Some ergonomic and cosmetic updates are made to the integration/replay
and integration/parse packages, following a pass through the code:
 + In the README, a some typos are corrected.
 + A few symbols are renamed:
   - Direction->MsgType, since this type is more than a client-server
     direction
   - logRec->scanLogs, to be more consistent with the naming convention
     SplitFuncs in the bufio package
   - CamelCase is applied in a few places.
 + Context is plumbed through, rather than use a package local ctx.
 + In a few cases, returning an error is preferred over log.Fatal.
 + Some duplicated code is deleted, and types from the parse package are
   reused. (this was probably cruft from the repo migration)
 + The logfile is made an argument rather than a flag to the replay
   tool.

Change-Id: Ie72e6e8a4d7020d8cf708f6791353897791bcc86
Reviewed-on: https://go-review.googlesource.com/c/tools/+/211057
Reviewed-by: Peter Weinberger <pjw@google.com>
2020-01-02 14:09:08 +00:00
..
govim gopls/integration: add a first cut of govim integration tests 2019-12-23 18:47:16 +00:00
parse gopls/integration: cosmetic/ergonomic updates 2020-01-02 14:09:08 +00:00
replay gopls/integration: cosmetic/ergonomic updates 2020-01-02 14:09:08 +00:00