1
0
mirror of https://github.com/golang/go synced 2024-11-17 16:04:47 -07:00
go/src
Matthew Dempsky 6da1661371 [dev.typeparams] cmd/compile: simplify inlining variadic calls
We already have and use FixVariadicCall to normalize non-dotted calls
to variadic functions elsewhere in the compiler to simplify rewriting
of function calls. This CL updates inl.go to use it too.

A couple tests need to be updated to (correctly) expect diagnostics
about "... argument" instead of a slice literal. This is because
inl.go previously failed to set Implicit on the slice literal node.

Change-Id: I76bd79b95ae1f16e3b26ff7e9e1c468f538fd1f0
Reviewed-on: https://go-review.googlesource.com/c/go/+/323009
Trust: Matthew Dempsky <mdempsky@google.com>
Trust: Dan Scales <danscales@google.com>
Run-TryBot: Matthew Dempsky <mdempsky@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Dan Scales <danscales@google.com>
2021-05-26 23:50:45 +00:00
..
archive
bufio
builtin
bytes
cmd [dev.typeparams] cmd/compile: simplify inlining variadic calls 2021-05-26 23:50:45 +00:00
compress
container
context
crypto crypto/x509: add new FreeBSD 12.2+ trusted certificate folder 2021-05-20 17:06:05 +00:00
database/sql
debug debug/macho: fix a typo in macho.go 2021-05-14 00:56:52 +00:00
embed
encoding
errors
expvar
flag
fmt
go [dev.typeparams] all: merge master (f22ec51) into dev.typeparams 2021-05-25 15:37:20 -07:00
hash
html
image
index/suffixarray
internal [dev.typeparams] internal/buildcfg: enable defer/go wrapping everywhere 2021-05-24 22:07:39 +00:00
io io/fs: added an example for io/fs.WalkDir 2021-05-21 03:21:56 +00:00
log
math all: add //go:build lines to assembly files 2021-05-13 09:12:17 +00:00
mime
net net: verify results from Lookup* are valid domain names 2021-05-24 22:27:31 +00:00
os os: document that StartProcess puts files into blocking mode 2021-05-21 20:38:43 +00:00
path
plugin
reflect [dev.typeparams] reflect: use internal/abi.FuncPCABI0 to take address of assembly functions 2021-05-24 21:05:34 +00:00
regexp regexp: fix repeat of preferred empty match 2021-05-13 14:52:20 +00:00
runtime [dev.typeparams] all: merge master (f22ec51) into dev.typeparams 2021-05-25 15:37:20 -07:00
sort
strconv
strings
sync all: add //go:build lines to assembly files 2021-05-13 09:12:17 +00:00
syscall syscall: document NewCallback and NewCallbackCDecl limitations 2021-05-20 13:19:43 +00:00
testdata
testing
text
time time: rewrite the documentation for layout strings 2021-05-18 02:39:04 +00:00
unicode
unsafe
vendor cmd/internal/moddeps: use filepath.SkipDir only on directories 2021-05-19 15:20:08 +00:00
all.bash
all.bat
all.rc
bootstrap.bash
buildall.bash
clean.bash
clean.bat
clean.rc
cmp.bash
go.mod cmd/internal/moddeps: use filepath.SkipDir only on directories 2021-05-19 15:20:08 +00:00
go.sum cmd/go: add a -compat flag to 'go mod tidy' 2021-05-25 13:18:26 +00:00
make.bash make.bash: fix misuse of continue 2021-05-18 15:00:55 +00:00
make.bat
Make.dist
make.rc
race.bash
race.bat
README.vendor
run.bash
run.bat
run.rc

Vendoring in std and cmd
========================

The Go command maintains copies of external packages needed by the
standard library in the src/vendor and src/cmd/vendor directories.

In GOPATH mode, imports of vendored packages are resolved to these
directories following normal vendor directory logic
(see golang.org/s/go15vendor).

In module mode, std and cmd are modules (defined in src/go.mod and
src/cmd/go.mod). When a package outside std or cmd is imported
by a package inside std or cmd, the import path is interpreted
as if it had a "vendor/" prefix. For example, within "crypto/tls",
an import of "golang.org/x/crypto/cryptobyte" resolves to
"vendor/golang.org/x/crypto/cryptobyte". When a package with the
same path is imported from a package outside std or cmd, it will
be resolved normally. Consequently, a binary may be built with two
copies of a package at different versions if the package is
imported normally and vendored by the standard library.

Vendored packages are internally renamed with a "vendor/" prefix
to preserve the invariant that all packages have distinct paths.
This is necessary to avoid compiler and linker conflicts. Adding
a "vendor/" prefix also maintains the invariant that standard
library packages begin with a dotless path element.

The module requirements of std and cmd do not influence version
selection in other modules. They are only considered when running
module commands like 'go get' and 'go mod vendor' from a directory
in GOROOT/src.

Maintaining vendor directories
==============================

Before updating vendor directories, ensure that module mode is enabled.
Make sure GO111MODULE=off is not set ('on' or 'auto' should work).

Requirements may be added, updated, and removed with 'go get'.
The vendor directory may be updated with 'go mod vendor'.
A typical sequence might be:

    cd src
    go get -d golang.org/x/net@latest
    go mod tidy
    go mod vendor

Use caution when passing '-u' to 'go get'. The '-u' flag updates
modules providing all transitively imported packages, not only
the module providing the target package.

Note that 'go mod vendor' only copies packages that are transitively
imported by packages in the current module. If a new package is needed,
it should be imported before running 'go mod vendor'.