Heschi Kreinick fda23558a1 internal/lsp/cache: only refresh imports cache every 30 seconds ... Loading completion suggestions can be slow, especially in GOPATH mode where basically anything can change at any time. As a compromise, cache everything for 30 seconds. Specifically, after a completion operation finishes, if the cache is more than 30 seconds old, refresh it asynchronously. That keeps user-facing latency consistent, without chewing up CPU when the editor isn't in use. It does mean that if you walk away for an hour and come back, the first completion may be stale. In module mode this is relatively benign. The only things the longer caching affects are the main module and replace targets, and relevant packages in those will generally be loaded by gopls, so they'll have full, up-to-date type information regardless. In GOPATH mode this may be more troublesome, since it affects everything. In particular, go get -u of a package that isn't imported yet won't be reflected until the cache period expires. I think that's a rare enough case not to worry about. Change-Id: Iaadfd0ff647cda2b1dcdead9254b5492b397e86e Reviewed-on: https://go-review.googlesource.com/c/tools/+/205163 Run-TryBot: Heschi Kreinick <heschi@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Rebecca Stambler <rstambler@golang.org>		2019-11-04 21:31:29 +00:00
..
testdata/mod	imports: rename to internal/imports	2019-05-20 21:49:35 +00:00
fix_test.go	internal/imports: cache GOPATH, exports	2019-11-04 21:31:17 +00:00
fix.go	internal/lsp/cache: only refresh imports cache every 30 seconds	2019-11-04 21:31:29 +00:00
imports_test.go	all: skip more memory-intensive tests on linux-arm	2019-08-30 17:05:41 +00:00
imports.go	internal/imports: provide export completions for unimported packages	2019-11-04 21:30:58 +00:00
mkindex.go	imports: rename to internal/imports	2019-05-20 21:49:35 +00:00
mkstdlib.go	internal/imports: cache GOPATH, exports	2019-11-04 21:31:17 +00:00
mod_112_test.go	imports: rename to internal/imports	2019-05-20 21:49:35 +00:00
mod_114_test.go	internal/imports: support vendoring in module mode	2019-10-24 21:04:39 +00:00
mod_cache_test.go	internal/imports: cache GOPATH, exports	2019-11-04 21:31:17 +00:00
mod_cache.go	internal/imports: cache GOPATH, exports	2019-11-04 21:31:17 +00:00
mod_pre114_test.go	internal/imports: support vendoring in module mode	2019-10-24 21:04:39 +00:00
mod_test.go	internal/imports: sort import candidates by "relevance"	2019-10-30 22:54:52 +00:00
mod.go	internal/imports: cache GOPATH, exports	2019-11-04 21:31:17 +00:00
proxy_112_test.go	imports: rename to internal/imports	2019-05-20 21:49:35 +00:00
proxy_113_test.go	imports: rename to internal/imports	2019-05-20 21:49:35 +00:00
sortimports.go	internal/imports: merge import declarations	2019-08-14 23:54:02 +00:00
zstdlib.go	internal/imports: cache GOPATH, exports	2019-11-04 21:31:17 +00:00