1
0
mirror of https://github.com/golang/go synced 2024-11-18 20:44:45 -07:00
go/internal/span
Heschi Kreinick 761dbfd69d internal/span: support line directives
When //line directives are in play, the ast.File's Offset function will
return offsets in the generated file. We want offsets in the authored
file, so we need to pass a Converter for the authored file, in addition
to the ast.File for the generated file. For the same reason, we have to
start (Range).Span() by translating into positions in the authored file,
then calculate offsets from that.

A lot of call sites outside of the LSP don't pass the Converter, but
they probably don't matter much. I think everything inside does because
it ends up using mappedRange.

Updates golang/go#35720.

Change-Id: I7be09b3a50720b078e862d48cfdb02208f8187ae
Reviewed-on: https://go-review.googlesource.com/c/tools/+/208501
Run-TryBot: Heschi Kreinick <heschi@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Ian Cottrell <iancottrell@google.com>
Reviewed-by: Rebecca Stambler <rstambler@golang.org>
2019-11-25 19:20:43 +00:00
..
parse.go internal/span: change to private fields 2019-03-15 18:05:47 +00:00
span_test.go all: fix more typos 2019-09-11 15:13:14 +00:00
span.go internal/span: end of file is now last line +1 2019-10-07 18:54:44 +00:00
token111.go internal/span: adding a source location package to unify the pos conversions 2019-03-08 14:21:31 +00:00
token112.go internal/span: adding a source location package to unify the pos conversions 2019-03-08 14:21:31 +00:00
token_test.go internal/span: support line directives 2019-11-25 19:20:43 +00:00
token.go internal/span: support line directives 2019-11-25 19:20:43 +00:00
uri_test.go internal/span: handle escaping file URIs 2019-09-16 17:14:20 +00:00
uri.go internal/span: handle escaping file URIs 2019-09-16 17:14:20 +00:00
utf16_test.go internal/span: handle character values beyond end of line in FromUTF16Column 2019-07-06 07:08:13 +00:00
utf16.go internal/span: handle invalid column values to avoid crashing 2019-09-23 19:53:54 +00:00