mirror of
https://github.com/golang/go
synced 2024-11-19 06:24:41 -07:00
6afc7fcab5
Invert "useDeepCompletions" config flag to "disableDeepCompletion" and separate out "disableFuzzyMatching" which reverts to the previous prefix matching behavior. I separated fuzzy matching tests out to a separate file so they aren't entangled with deep completion tests. In coming up with representative test cases I found a couple issues which I fixed: - We were treating a fuzzy matcher score of 0 as no match, but the matcher returns 0 for candidates that match but have no bonuses. I changed the matcher interface so that a score of 0 counts as a match. For example, this was preventing a pattern of "o" from matching "foo". - When we lower a candidate's score based on its depth, we were subtracting a static multiplier which could result in the score going negative. A negative score messes up future score weighting because multiplying it by a value in the range [0, 1) makes it bigger instead of smaller. Fix by scaling a candidate's score based on its depth rather than subtracting a constant factor. Updates golang/go#32754 Change-Id: Ie6f9111f1696b0d067d08f7eed7b0a338ad9cd67 Reviewed-on: https://go-review.googlesource.com/c/tools/+/192137 Run-TryBot: Rebecca Stambler <rstambler@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Rebecca Stambler <rstambler@golang.org>
91 lines
2.6 KiB
Go
91 lines
2.6 KiB
Go
// Copyright 2019 The Go Authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style
|
|
// license that can be found in the LICENSE file.
|
|
|
|
package deepcomplete
|
|
|
|
import "context" //@item(ctxPackage, "context", "\"context\"", "package")
|
|
|
|
type deepA struct {
|
|
b deepB //@item(deepBField, "b", "deepB", "field")
|
|
}
|
|
|
|
type deepB struct {
|
|
}
|
|
|
|
func wantsDeepB(deepB) {}
|
|
|
|
func _() {
|
|
var a deepA //@item(deepAVar, "a", "deepA", "var")
|
|
a.b //@item(deepABField, "a.b", "deepB", "field")
|
|
wantsDeepB(a) //@complete(")", deepABField, deepAVar)
|
|
|
|
deepA{a} //@snippet("}", deepABField, "a.b", "a.b")
|
|
}
|
|
|
|
func wantsContext(context.Context) {}
|
|
|
|
func _() {
|
|
context.Background() //@item(ctxBackground, "context.Background", "func() context.Context", "func", "Background returns a non-nil, empty Context.")
|
|
context.TODO() //@item(ctxTODO, "context.TODO", "func() context.Context", "func", "TODO returns a non-nil, empty Context.")
|
|
context.WithValue(nil, nil, nil) //@item(ctxWithValue, "context.WithValue", "func(parent context.Context, key interface{}, val interface{}) context.Context", "func", "WithValue returns a copy of parent in which the value associated with key is val.")
|
|
|
|
wantsContext(c) //@complete(")", ctxBackground, ctxTODO, ctxWithValue, ctxPackage)
|
|
}
|
|
|
|
func _() {
|
|
type deepCircle struct { //@item(deepCircleStruct, "deepCircle", "struct{...}", "struct")
|
|
*deepCircle
|
|
}
|
|
var circle deepCircle //@item(deepCircle, "circle", "deepCircle", "var")
|
|
circle.deepCircle //@item(deepCircleField, "circle.deepCircle", "*deepCircle", "field")
|
|
var _ deepCircle = circ //@complete(" //", deepCircle, deepCircleField)
|
|
}
|
|
|
|
func _() {
|
|
type deepEmbedC struct {
|
|
}
|
|
type deepEmbedB struct {
|
|
deepEmbedC
|
|
}
|
|
type deepEmbedA struct {
|
|
deepEmbedB
|
|
}
|
|
|
|
wantsC := func(deepEmbedC) {}
|
|
|
|
var a deepEmbedA //@item(deepEmbedA, "a", "deepEmbedA", "var")
|
|
a.deepEmbedB //@item(deepEmbedB, "a.deepEmbedB", "deepEmbedB", "field")
|
|
a.deepEmbedC //@item(deepEmbedC, "a.deepEmbedC", "deepEmbedC", "field")
|
|
wantsC(a) //@complete(")", deepEmbedC, deepEmbedA, deepEmbedB)
|
|
}
|
|
|
|
func _() {
|
|
type nested struct {
|
|
a int
|
|
n *nested //@item(deepNestedField, "n", "*nested", "field")
|
|
}
|
|
|
|
nested{
|
|
a: 123, //@complete(" //", deepNestedField)
|
|
}
|
|
}
|
|
|
|
func _() {
|
|
var a struct {
|
|
b struct {
|
|
c int
|
|
}
|
|
d int
|
|
}
|
|
|
|
a.d //@item(deepAD, "a.d", "int", "field")
|
|
a.b.c //@item(deepABC, "a.b.c", "int", "field")
|
|
a.b //@item(deepAB, "a.b", "struct{...}", "field")
|
|
a //@item(deepA, "a", "struct{...}", "var")
|
|
|
|
// "a.d" should be ranked above the deeper "a.b.c"
|
|
var i int
|
|
i = a //@complete(" //", deepAD, deepABC, deepA, deepAB)
|
|
}
|