1
0
mirror of https://github.com/golang/go synced 2024-09-30 22:58:34 -06:00
go/internal/lsp
Rob Findley 6a72e3782c internal/lsp/fake: don't lock while calling formatting
While trying to be pragmatic, I simply locked the fake.Editor while
calling textDocument/formatting. This did indeed manifest later on as a
deadlock, so instead we release the lock but fail if the buffer version
changes while awaiting the formatting call.

Change-Id: I0ca24a502f3118e76de306a016449bbe665e70e4
Reviewed-on: https://go-review.googlesource.com/c/tools/+/228230
Run-TryBot: Robert Findley <rfindley@google.com>
Reviewed-by: Rebecca Stambler <rstambler@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
2020-04-14 20:55:25 +00:00
..
analysis internal/lsp: add type error fixes to existing diagnostics 2020-04-08 01:45:16 +00:00
browser internal/lsp: add version and bug commands 2019-05-11 04:16:02 +00:00
cache internal/lsp/cache: hide type errors if we fix up the AST 2020-04-10 04:07:51 +00:00
cmd internal/lsp: add type error fixes to existing diagnostics 2020-04-08 01:45:16 +00:00
debug internal/lsp: make tag iteration allocation-free 2020-04-08 13:20:38 +00:00
diff internal/lsp/diff/difftest: ignore for GOOS=illumos 2020-04-14 02:36:50 +00:00
fake internal/lsp/fake: don't lock while calling formatting 2020-04-14 20:55:25 +00:00
fuzzy internal/lsp: fix errors found by staticcheck 2020-03-19 19:20:54 +00:00
helper internal/lsp: change to helper.go to output a formatted file 2020-01-31 20:35:38 +00:00
lsprpc internal/jsonrpc2: split reply from request 2020-04-13 01:58:12 +00:00
mod internal/lsp: add type error fixes to existing diagnostics 2020-04-08 01:45:16 +00:00
protocol internal/jsonrpc2: split reply from request 2020-04-13 01:58:12 +00:00
regtest internal/lsp/regtest: put testing.T back in the test func signature 2020-04-14 18:42:46 +00:00
snippet all: fix broken links to LSP specification 2019-10-02 18:32:53 +00:00
source internal/lsp: add an extra bounds check to avoid nil pointers 2020-04-10 19:49:07 +00:00
testdata internal/lsp: add type error fixes to existing diagnostics 2020-04-08 01:45:16 +00:00
tests internal/lsp: add type error fixes to existing diagnostics 2020-04-08 01:45:16 +00:00
code_action.go internal/lsp: add type error fixes to existing diagnostics 2020-04-08 01:45:16 +00:00
command.go internal/lsp/cache: add concurrency error check for go cmds 2020-04-08 03:22:09 +00:00
completion_test.go internal/span,lsp: disambiguate URIs, DocumentURIs, and paths 2020-02-14 22:51:03 +00:00
completion.go internal/lsp: avoid logging context cancellation 2020-03-31 01:46:33 +00:00
definition.go internal/lsp/source: return location(s) for imported packages 2020-03-09 16:25:02 +00:00
diagnostics.go internal/lsp: add type error fixes to existing diagnostics 2020-04-08 01:45:16 +00:00
folding_range.go internal/lsp: check for file URIs on LSP requests 2020-02-14 22:51:26 +00:00
format.go internal/lsp: support textDocument/formatting for .mod extension 2020-03-06 13:51:27 +00:00
general.go internal/jsonrpc2: replace NewErrorf with fmt.Errorf 2020-04-13 01:57:14 +00:00
generate.go internal/lsp, go/packages: don't log context cancellation errors 2020-04-03 19:08:13 +00:00
highlight.go internal/lsp: move the telemetry package 2020-03-18 13:22:49 +00:00
hover.go internal/lsp: support textDocument/hover for .mod extension 2020-02-26 15:59:49 +00:00
implementation.go internal/lsp: check for file URIs on LSP requests 2020-02-14 22:51:26 +00:00
link.go internal/lsp: linkify IP addresses in textDocument/documentLink 2020-04-10 03:56:59 +00:00
lsp_test.go internal/lsp: add type error fixes to existing diagnostics 2020-04-08 01:45:16 +00:00
references.go internal/lsp: refactor references/rename/implementations 2020-03-27 17:09:18 +00:00
rename.go internal/lsp: check for file URIs on LSP requests 2020-02-14 22:51:26 +00:00
reset_golden.sh internal/lsp: fix regeneration of golden files 2019-09-25 13:16:59 +00:00
server_gen.go x/tools/gopls: add support for $/progress functionality 2020-03-16 21:25:24 +00:00
server.go internal/jsonrpc2: replace NewErrorf with fmt.Errorf 2020-04-13 01:57:14 +00:00
signature_help.go internal/telemetry: delete the event.TagOf method 2020-03-18 13:23:15 +00:00
symbols.go internal/lsp: move the telemetry package 2020-03-18 13:22:49 +00:00
text_synchronization.go internal/jsonrpc2: replace NewErrorf with fmt.Errorf 2020-04-13 01:57:14 +00:00
workspace_symbol.go internal/lsp: migrate telemetry to using the event package 2020-03-12 03:59:16 +00:00
workspace.go internal/lsp: generate boilerplate stubs for type Server 2020-01-24 14:41:51 +00:00