66e562cc52
In a position independent executable the data or BSS may be located close to the end of memory. If it is placed closer than rootBlockBytes, then the calculations in markrootBlock would overflow, and the test that ensures that n is not larger than n0 would fail. This would then cause scanblock to scan data that it shouldn't, using an effectively random ptrmask, leading to program crashes. No test because the only way to test it is to build a PIE and convince the kernel to put the data section near the end of memory, and I don't know how to do that. Or perhaps we could use a linker script, but that is painful. The new code is algebraically identical to the original code, but avoids the potential overflow of b+rootBlockBytes. Change-Id: Ieb4e5465174bb762b063d2491caeaa745017345e Reviewed-on: https://go-review.googlesource.com/c/go/+/195717 Run-TryBot: Ian Lance Taylor <iant@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Austin Clements <austin@google.com> |
||
---|---|---|
.github | ||
api | ||
doc | ||
lib/time | ||
misc | ||
src | ||
test | ||
.gitattributes | ||
.gitignore | ||
AUTHORS | ||
CONTRIBUTING.md | ||
CONTRIBUTORS | ||
favicon.ico | ||
LICENSE | ||
PATENTS | ||
README.md | ||
robots.txt | ||
SECURITY.md |
The Go Programming Language
Go is an open source programming language that makes it easy to build simple, reliable, and efficient software.
Gopher image by Renee French, licensed under Creative Commons 3.0 Attributions license.
Our canonical Git repository is located at https://go.googlesource.com/go. There is a mirror of the repository at https://github.com/golang/go.
Unless otherwise noted, the Go source files are distributed under the BSD-style license found in the LICENSE file.
Download and Install
Binary Distributions
Official binary distributions are available at https://golang.org/dl/.
After downloading a binary release, visit https://golang.org/doc/install or load doc/install.html in your web browser for installation instructions.
Install From Source
If a binary distribution is not available for your combination of operating system and architecture, visit https://golang.org/doc/install/source or load doc/install-source.html in your web browser for source installation instructions.
Contributing
Go is the work of thousands of contributors. We appreciate your help!
To contribute, please read the contribution guidelines: https://golang.org/doc/contribute.html
Note that the Go project uses the issue tracker for bug reports and proposals only. See https://golang.org/wiki/Questions for a list of places to ask questions about the Go language.