Tal Shprecher 24967ec122 cmd/compile: make enqueued map keys fail validation on forward types ... Map keys are currently validated in multiple locations but share a common validation routine. The problem is that early validations should be lenient enough to allow for forward types while the final validations should not. The final validations should fail on forward types since they've already settled. This change also separates the key type checking from the creation of the map via typMap. Instead of the mapqueue being populated in copytype() by checking the map line number, it's populated in the same block that validates the key type. This isolates key validation logic while type checking. Fixes #14988 Change-Id: Ia47cf6213585d6c63b3a35249104c0439feae658 Reviewed-on: https://go-review.googlesource.com/21830 Reviewed-by: Matthew Dempsky <mdempsky@google.com> Run-TryBot: Matthew Dempsky <mdempsky@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org>		2016-04-13 08:43:12 +00:00
..
bench	encoding/base64: fix streaming decode of padding-free base64	2016-01-08 15:07:45 +00:00
bugs
chan
ddd2.dir
dwarf
fixedbugs	cmd/compile: make enqueued map keys fail validation on forward types	2016-04-13 08:43:12 +00:00
import2.dir
import4.dir	test: adjust gccgo expected import errors	2015-10-07 14:37:44 +00:00
interface
intrinsic.dir	cmd/compile: added some intrinsics to SSA back end	2016-03-28 16:29:59 +00:00
ken	all: fix spelling mistakes	2016-04-03 17:03:15 +00:00
method4.dir
safe
stress
syntax	cmd/compile: use bufio.Reader directly in lexer	2016-03-11 21:27:23 +00:00
64bit.go
235.go
alias1.go
alias.go
append.go
args.go
assign1.go
assign.go
atomicload.go	cmd/compile: keep value use counts in SSA	2016-03-17 04:20:02 +00:00
bigalg.go
bigmap.go
blank1.go	cmd/compile: don't allow blank method declarations on builtins	2015-12-02 18:26:38 +00:00
blank.go
bom.go
bombad.go
bounds.go
chancap.go
chanlinear.go
char_lit1.go
char_lit.go
checkbce.go	cmd/compile: bce when max and limit are consts	2016-04-11 16:01:22 +00:00
clearfat.go
closedchan.go
closure1.go
closure2.go
closure.go
cmp6.go
cmp.go
cmplx.go
cmplxdivide1.go
cmplxdivide.c
cmplxdivide.go
complit1.go
complit.go
compos.go
const1.go
const2.go
const3.go
const4.go
const5.go
const6.go
const.go	cmd/compile: allow huge rsh in constants arithmetic	2015-08-21 20:27:22 +00:00
convert1.go
convert3.go
convert.go
convlit1.go
convlit.go
convT2X.go
copy.go
crlf.go
ddd1.go
ddd2.go
ddd.go
decl.go
declbad.go
defer.go
deferfin.go
deferprint.go
deferprint.out
divide.go
divmod.go
empty.go
env.go
eof1.go
eof.go
errchk
escape2.go	cmd/compile: better modeling of escape across loop levels	2016-01-13 04:01:00 +00:00
escape2n.go	cmd/compile: better modeling of escape across loop levels	2016-01-13 04:01:00 +00:00
escape3.go
escape4.go
escape5.go
escape_array.go
escape_because.go	cmd/compile: escape analysis explanations added to -m -m output	2016-03-17 13:29:48 +00:00
escape_calls.go
escape_closure.go	cmd/compile: note escape of parts of closured-capture vars	2016-04-05 18:10:09 +00:00
escape_field.go
escape_iface.go	cmd/compile: avoid leak of dottype expression if type does not contain pointers.	2016-02-19 16:10:14 +00:00
escape_indir.go
escape_level.go
escape_map.go
escape_param.go
escape_slice.go
escape_struct_param1.go
escape_struct_param2.go
escape_struct_return.go
escape.go
fibo.go
finprofiled.go	runtime: fix finalization and profiling of tiny allocations	2015-11-03 18:57:18 +00:00
float_lit2.go
float_lit3.go
float_lit.go
floatcmp.go
for.go
func1.go
func2.go
func3.go
func4.go
func5.go
func6.go
func7.go
func8.go	test: use go:noinline consistently	2015-11-03 02:01:34 +00:00
func.go
funcdup2.go
funcdup.go
gc1.go
gc2.go
gc.go
gcstring.go
goprint.go	test: make goprint.go wait for goroutine termination	2016-04-06 18:45:00 +00:00
goprint.out
goto.go
heapsampling.go	test: really force heap profile update in heapsampling.go	2015-11-12 18:32:13 +00:00
helloworld.go
helloworld.out
if.go
import1.go
import2.go
import4.go
import5.go
import.go
index0.go
index1.go
index2.go
index.go
indirect1.go
indirect.go
init1.go
init.go
initcomma.go
initialize.go
initializerr.go
initloop.go	cmd/compile: use []*Node instead of NodeList in sinit	2015-09-05 02:25:01 +00:00
inline.go	cmd/compile: allow inlining of functions with switch statements	2016-03-21 23:05:10 +00:00
int_lit.go
intcvt.go
intrinsic.go	cmd/compile: added some intrinsics to SSA back end	2016-03-28 16:29:59 +00:00
iota.go
label1.go
label.go
linkmain_run.go	test: fix linkmain test	2015-12-17 23:36:13 +00:00
linkmain.go	cmd/link: reject non-package main toplevel.a file, remove dead code	2015-12-17 20:59:51 +00:00
linkx_run.go	cmd/link: remove alternate -X flag spelling	2016-02-19 01:35:25 +00:00
linkx.go
literal.go
live1.go
live2.go	[dev.ssa] cmd/compile: default compile+test with SSA	2015-10-30 20:35:20 +00:00
live_ssa.go	cmd/compile: fix x=x assignments	2016-04-06 15:04:32 +00:00
live_syscall.go	cmd/compile: recognize Syscall-like functions for liveness analysis	2016-01-14 01:16:45 +00:00
live.go	[dev.ssa] cmd/compile: default compile+test with SSA	2015-10-30 20:35:20 +00:00
loopbce.go	cmd/compile: bce when max and limit are consts	2016-04-11 16:01:22 +00:00
mallocfin.go
map1.go
map.go
maplinear.go
method1.go	cmd/compile: ignore receiver parameters in Eqtype	2016-03-17 00:38:15 +00:00
method2.go
method3.go
method4.go
method5.go
method.go
named1.go
named.go
nil.go
nilcheck.go	[dev.ssa] cmd/compile: make cse faster	2016-01-28 20:59:20 +00:00
nilptr2.go
nilptr3_ssa.go	[dev.ssa] cmd/compile: get rid of nil checks before float loads/stores	2016-02-26 04:33:46 +00:00
nilptr3.go	test: skip nilptr3 test on s390x	2016-04-08 17:51:46 +00:00
nilptr4.go
nilptr.go
nosplit.go	test: add s390x case to nosplit test	2016-03-21 08:14:51 +00:00
nul1.go
opt_branchlikely.go	[dev.ssa] cmd/compile: adjust branch likeliness for calls/loops	2016-03-01 20:09:41 +00:00
parentype.go
peano.go
phiopt.go	[dev.ssa] cmd/compile/internal/ssa: simplify boolean phis	2016-03-01 17:56:13 +00:00
print.go
print.out
printbig.go
printbig.out
prove.go	cmd/compile: handle non-negatives in prove	2016-04-02 20:34:38 +00:00
range.go
recover1.go
recover2.go
recover3.go
recover4.go	test: move allocation before munmap in recover4	2015-09-16 08:51:48 +00:00
recover.go
reflectmethod1.go	cmd/compile: track reflect.Type.Method in deadcode	2016-03-11 21:19:20 +00:00
reflectmethod2.go	cmd/compile: track reflect.Type.Method in deadcode	2016-03-11 21:19:20 +00:00
reflectmethod3.go	cmd/compile: track reflect.Type.Method in deadcode	2016-03-11 21:19:20 +00:00
reflectmethod4.go	cmd/link: treat reflect.Value.Method like Call	2016-03-11 22:07:02 +00:00
rename1.go
rename.go
reorder2.go	test: use go:noinline consistently	2015-11-03 02:01:34 +00:00
reorder.go
return.go
rotate0.go
rotate1.go
rotate2.go
rotate3.go
rotate.go
run.go	cmd/compile: fix build	2016-03-31 18:00:36 +00:00
rune.go
runtime.go
shift1.go
shift2.go
sieve.go
sigchld.go
sigchld.out
simassign.go
sinit_run.go
sinit.go
sizeof.go
slice3.go
slice3err.go
slicecap.go
sliceopt.go	[dev.ssa] cmd/compile: default compile+test with SSA	2015-10-30 20:35:20 +00:00
solitaire.go
stack.go
strength.go	cmd/compile: generalize strength reduction of mulq	2016-03-30 22:27:13 +00:00
string_lit.go
stringrange.go
struct0.go
switch2.go	cmd/compile: address several more 1.6 TODOs in parser	2015-11-21 07:21:23 +00:00
switch3.go
switch4.go
switch.go
tinyfin.go	runtime: fix finalization and profiling of tiny allocations	2015-11-03 18:57:18 +00:00
torture.go
turing.go
typecheck.go
typecheckloop.go	cmd/compile: convert typecheck_stack to []*Node	2015-09-06 23:50:51 +00:00
typeswitch1.go
typeswitch2.go
typeswitch3.go
typeswitch.go
undef.go
utf.go
varerr.go
varinit.go
writebarrier.go	cmd/compile: don't write back unchanged slice results	2016-03-21 23:40:18 +00:00
zerodivide.go