1
0
mirror of https://github.com/golang/go synced 2024-10-01 16:28:33 -06:00
go/internal/lsp/cache
Rebecca Stambler 3e6e7c4239 internal/lsp: add ID to the package cache key
Our original caching plan was to use only the file ParseGoHandles as
cache keys to define a given package. However, because of package test
variants, we cannot rely on files alone. A package may have the exact
same set of files, but be a test variant. Add the ID to the key to avoid
clobbering entries in the cache.

Also, remove the unused metadata ID cache.

Change-Id: I4b33de1f83f6c769d23441e98a2a7324ff0fa1b0
Reviewed-on: https://go-review.googlesource.com/c/tools/+/194571
Run-TryBot: Rebecca Stambler <rstambler@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Ian Cottrell <iancottrell@google.com>
2019-09-10 22:12:34 +00:00
..
cache.go internal/lsp: move configuration options to structs 2019-09-06 17:30:54 +00:00
check.go internal/lsp: add ID to the package cache key 2019-09-10 22:12:34 +00:00
external.go internal/lsp: split the telemetry library out 2019-08-15 21:28:02 +00:00
file.go internal/lsp: fix deadlock in type-checking 2019-09-05 03:50:54 +00:00
gofile.go internal/lsp: remove the GetToken and GetAST functions 2019-09-09 18:10:35 +00:00
load.go internal/lsp: add ID to the package cache key 2019-09-10 22:12:34 +00:00
modfile.go internal/lsp: use x/xerrors to create new errors 2019-08-06 19:46:56 +00:00
parse.go internal/lsp: fix completion for nested *ast.BadStmt 2019-09-10 16:55:22 +00:00
pkg.go internal/lsp: derive ASTs from type information 2019-09-10 13:53:09 +00:00
session.go internal/lsp: add ID to the package cache key 2019-09-10 22:12:34 +00:00
sumfile.go internal/lsp: use x/xerrors to create new errors 2019-08-06 19:46:56 +00:00
token.go internal/lsp: unlabel context, log errors when canceled 2019-08-20 20:39:21 +00:00
view.go internal/lsp: add ID to the package cache key 2019-09-10 22:12:34 +00:00
watcher.go internal/lsp: fix deadlocks loading lots of files at once 2019-07-03 17:22:52 +00:00