Ian Cottrell 2f43c6d1a2 internal/span: change to private fields ... Change span to hide its fields and have validating accessors This catches the cases where either the offset or the position is being used when it was not set. It also normalizes the forms as the API now controls them, and allows us to simplify some of the logic. The converters are now allowed to return an error, which lets us cleanly propagate bad cases. The lsp was then converted to the new format, and also had some error checking of its own added on the top. All this allowed me to find and fix a few issues, most notably a case where the wrong column mapper was being used during the conversion of definition results. Change-Id: Iebdf8901e8269b28aaef60caf76574baa25c46d4 Reviewed-on: https://go-review.googlesource.com/c/tools/+/167858 Run-TryBot: Ian Cottrell <iancottrell@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Rebecca Stambler <rstambler@golang.org>		2019-03-15 18:05:47 +00:00
..
preserve	tools/cmd/gopls: modify gopls to use automatcally generated types	2019-03-12 15:13:52 +00:00
typescript	tools/internal/lsp/protocol: generate LSP protocol types from source	2019-03-12 15:15:45 +00:00
client.go	internal/jsonrpc2: change to a more synchronous dispatch model	2018-11-14 19:09:51 +00:00
doc.go	internal/lsp: the core lsp protocol	2018-09-25 15:17:08 +00:00
printers.go	internal/lsp: convert to the new location library	2019-03-13 19:34:21 +00:00
protocol.go	internal/jsonrpc2: change to a more synchronous dispatch model	2018-11-14 19:09:51 +00:00
server.go	tools/cmd/gopls: modify gopls to use automatcally generated types	2019-03-12 15:13:52 +00:00
span.go	internal/span: change to private fields	2019-03-15 18:05:47 +00:00
tsprotocol.go	tools/cmd/gopls: modify gopls to use automatcally generated types	2019-03-12 15:13:52 +00:00