mirror of
https://github.com/golang/go
synced 2024-11-17 16:14:42 -07:00
65518032b9
This makes for a more stable API for tools (including cmd/link itself) to extract the abi hash from a shared library and makes it possible at all for a library that has had the local symbol table removed. The existing note-writing code only supports writing notes into the very start of the object file so they are easy to find in core dumps. This doesn't apply to the "go" notes and means that all notes have to fit into a fixed size budget. That's annoying now we have more notes (and the next CL will add another one) so this does a little bit of work to make adding notes that do not have to go at the start of the file easier and moves the writing of the package list note over to that mechanism, which lets me revert a hack that increased the size budget mentioned above for -buildmode=shared builds. Change-Id: I6077a68d395c8a2bc43dec8506e73c71ef77d9b9 Reviewed-on: https://go-review.googlesource.com/10375 Reviewed-by: Ian Lance Taylor <iant@golang.org>
550 lines
16 KiB
Go
550 lines
16 KiB
Go
// Copyright 2015 The Go Authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style
|
|
// license that can be found in the LICENSE file.
|
|
|
|
package shared_test
|
|
|
|
import (
|
|
"bufio"
|
|
"bytes"
|
|
"debug/elf"
|
|
"encoding/binary"
|
|
"errors"
|
|
"flag"
|
|
"fmt"
|
|
"go/build"
|
|
"io"
|
|
"io/ioutil"
|
|
"log"
|
|
"math/rand"
|
|
"os"
|
|
"os/exec"
|
|
"path/filepath"
|
|
"strings"
|
|
"testing"
|
|
"time"
|
|
)
|
|
|
|
var gopathInstallDir, gorootInstallDir, suffix string
|
|
|
|
// This is the smallest set of packages we can link into a shared
|
|
// library (runtime/cgo is built implicitly).
|
|
var minpkgs = []string{"runtime", "sync/atomic"}
|
|
var soname = "libruntime,sync-atomic.so"
|
|
|
|
// run runs a command and calls t.Errorf if it fails.
|
|
func run(t *testing.T, msg string, args ...string) {
|
|
c := exec.Command(args[0], args[1:]...)
|
|
if output, err := c.CombinedOutput(); err != nil {
|
|
t.Errorf("executing %s (%s) failed %s:\n%s", strings.Join(args, " "), msg, err, output)
|
|
}
|
|
}
|
|
|
|
// goCmd invokes the go tool with the installsuffix set up by TestMain. It calls
|
|
// t.Errorf if the command fails.
|
|
func goCmd(t *testing.T, args ...string) {
|
|
newargs := []string{args[0], "-installsuffix=" + suffix}
|
|
if testing.Verbose() {
|
|
newargs = append(newargs, "-v")
|
|
}
|
|
newargs = append(newargs, args[1:]...)
|
|
c := exec.Command("go", newargs...)
|
|
var output []byte
|
|
var err error
|
|
if testing.Verbose() {
|
|
fmt.Printf("+ go %s\n", strings.Join(newargs, " "))
|
|
c.Stdout = os.Stdout
|
|
c.Stderr = os.Stderr
|
|
err = c.Run()
|
|
} else {
|
|
output, err = c.CombinedOutput()
|
|
}
|
|
if err != nil {
|
|
if t != nil {
|
|
t.Errorf("executing %s failed %v:\n%s", strings.Join(c.Args, " "), err, output)
|
|
} else {
|
|
log.Fatalf("executing %s failed %v:\n%s", strings.Join(c.Args, " "), err, output)
|
|
}
|
|
}
|
|
}
|
|
|
|
// TestMain calls testMain so that the latter can use defer (TestMain exits with os.Exit).
|
|
func testMain(m *testing.M) (int, error) {
|
|
// Because go install -buildmode=shared $standard_library_package always
|
|
// installs into $GOROOT, here are some gymnastics to come up with a unique
|
|
// installsuffix to use in this test that we can clean up afterwards.
|
|
myContext := build.Default
|
|
runtimeP, err := myContext.Import("runtime", ".", build.ImportComment)
|
|
if err != nil {
|
|
return 0, fmt.Errorf("import failed: %v", err)
|
|
}
|
|
for i := 0; i < 10000; i++ {
|
|
try := fmt.Sprintf("%s_%d_dynlink", runtimeP.PkgTargetRoot, rand.Int63())
|
|
err = os.Mkdir(try, 0700)
|
|
if os.IsExist(err) {
|
|
continue
|
|
}
|
|
if err == nil {
|
|
gorootInstallDir = try
|
|
}
|
|
break
|
|
}
|
|
if err != nil {
|
|
return 0, fmt.Errorf("can't create temporary directory: %v", err)
|
|
}
|
|
if gorootInstallDir == "" {
|
|
return 0, errors.New("could not create temporary directory after 10000 tries")
|
|
}
|
|
defer os.RemoveAll(gorootInstallDir)
|
|
|
|
// Some tests need to edit the source in GOPATH, so copy this directory to a
|
|
// temporary directory and chdir to that.
|
|
scratchDir, err := ioutil.TempDir("", "testshared")
|
|
if err != nil {
|
|
return 0, fmt.Errorf("TempDir failed: %v", err)
|
|
}
|
|
defer os.RemoveAll(scratchDir)
|
|
err = filepath.Walk(".", func(path string, info os.FileInfo, err error) error {
|
|
scratchPath := filepath.Join(scratchDir, path)
|
|
if info.IsDir() {
|
|
if path == "." {
|
|
return nil
|
|
}
|
|
return os.Mkdir(scratchPath, info.Mode())
|
|
} else {
|
|
fromBytes, err := ioutil.ReadFile(path)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
return ioutil.WriteFile(scratchPath, fromBytes, info.Mode())
|
|
}
|
|
})
|
|
if err != nil {
|
|
return 0, fmt.Errorf("walk failed: %v", err)
|
|
}
|
|
os.Setenv("GOPATH", scratchDir)
|
|
myContext.GOPATH = scratchDir
|
|
os.Chdir(scratchDir)
|
|
|
|
// All tests depend on runtime being built into a shared library. Because
|
|
// that takes a few seconds, do it here and have all tests use the version
|
|
// built here.
|
|
suffix = strings.Split(filepath.Base(gorootInstallDir), "_")[2]
|
|
goCmd(nil, append([]string{"install", "-buildmode=shared"}, minpkgs...)...)
|
|
|
|
myContext.InstallSuffix = suffix + "_dynlink"
|
|
depP, err := myContext.Import("dep", ".", build.ImportComment)
|
|
if err != nil {
|
|
return 0, fmt.Errorf("import failed: %v", err)
|
|
}
|
|
gopathInstallDir = depP.PkgTargetRoot
|
|
return m.Run(), nil
|
|
}
|
|
|
|
func TestMain(m *testing.M) {
|
|
flag.Parse()
|
|
exitCode, err := testMain(m)
|
|
if err != nil {
|
|
log.Fatal(err)
|
|
}
|
|
os.Exit(exitCode)
|
|
}
|
|
|
|
// The shared library was built at the expected location.
|
|
func TestSOBuilt(t *testing.T) {
|
|
_, err := os.Stat(filepath.Join(gorootInstallDir, soname))
|
|
if err != nil {
|
|
t.Error(err)
|
|
}
|
|
}
|
|
|
|
// The install command should have created a "shlibname" file for the
|
|
// listed packages (and runtime/cgo) indicating the name of the shared
|
|
// library containing it.
|
|
func TestShlibnameFiles(t *testing.T) {
|
|
pkgs := append([]string{}, minpkgs...)
|
|
pkgs = append(pkgs, "runtime/cgo")
|
|
for _, pkg := range pkgs {
|
|
shlibnamefile := filepath.Join(gorootInstallDir, pkg+".shlibname")
|
|
contentsb, err := ioutil.ReadFile(shlibnamefile)
|
|
if err != nil {
|
|
t.Errorf("error reading shlibnamefile for %s: %v", pkg, err)
|
|
continue
|
|
}
|
|
contents := strings.TrimSpace(string(contentsb))
|
|
if contents != soname {
|
|
t.Errorf("shlibnamefile for %s has wrong contents: %q", pkg, contents)
|
|
}
|
|
}
|
|
}
|
|
|
|
// Is a given offset into the file contained in a loaded segment?
|
|
func isOffsetLoaded(f *elf.File, offset uint64) bool {
|
|
for _, prog := range f.Progs {
|
|
if prog.Type == elf.PT_LOAD {
|
|
if prog.Off <= offset && offset < prog.Off+prog.Filesz {
|
|
return true
|
|
}
|
|
}
|
|
}
|
|
return false
|
|
}
|
|
|
|
func rnd(v int32, r int32) int32 {
|
|
if r <= 0 {
|
|
return v
|
|
}
|
|
v += r - 1
|
|
c := v % r
|
|
if c < 0 {
|
|
c += r
|
|
}
|
|
v -= c
|
|
return v
|
|
}
|
|
|
|
func readwithpad(r io.Reader, sz int32) ([]byte, error) {
|
|
data := make([]byte, rnd(sz, 4))
|
|
_, err := io.ReadFull(r, data)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
data = data[:sz]
|
|
return data, nil
|
|
}
|
|
|
|
type note struct {
|
|
name string
|
|
tag int32
|
|
desc string
|
|
section *elf.Section
|
|
}
|
|
|
|
// Read all notes from f. As ELF section names are not supposed to be special, one
|
|
// looks for a particular note by scanning all SHT_NOTE sections looking for a note
|
|
// with a particular "name" and "tag".
|
|
func readNotes(f *elf.File) ([]*note, error) {
|
|
var notes []*note
|
|
for _, sect := range f.Sections {
|
|
if sect.Type != elf.SHT_NOTE {
|
|
continue
|
|
}
|
|
r := sect.Open()
|
|
for {
|
|
var namesize, descsize, tag int32
|
|
err := binary.Read(r, f.ByteOrder, &namesize)
|
|
if err != nil {
|
|
if err == io.EOF {
|
|
break
|
|
}
|
|
return nil, fmt.Errorf("read namesize failed:", err)
|
|
}
|
|
err = binary.Read(r, f.ByteOrder, &descsize)
|
|
if err != nil {
|
|
return nil, fmt.Errorf("read descsize failed:", err)
|
|
}
|
|
err = binary.Read(r, f.ByteOrder, &tag)
|
|
if err != nil {
|
|
return nil, fmt.Errorf("read type failed:", err)
|
|
}
|
|
name, err := readwithpad(r, namesize)
|
|
if err != nil {
|
|
return nil, fmt.Errorf("read name failed:", err)
|
|
}
|
|
desc, err := readwithpad(r, descsize)
|
|
if err != nil {
|
|
return nil, fmt.Errorf("read desc failed:", err)
|
|
}
|
|
notes = append(notes, ¬e{name: string(name), tag: tag, desc: string(desc), section: sect})
|
|
}
|
|
}
|
|
return notes, nil
|
|
}
|
|
|
|
func dynStrings(path string, flag elf.DynTag) []string {
|
|
f, err := elf.Open(path)
|
|
defer f.Close()
|
|
if err != nil {
|
|
log.Fatal("elf.Open failed: ", err)
|
|
}
|
|
dynstrings, err := f.DynString(flag)
|
|
if err != nil {
|
|
log.Fatal("dynstring failed: ", err)
|
|
}
|
|
return dynstrings
|
|
}
|
|
|
|
func AssertIsLinkedTo(t *testing.T, path, lib string) {
|
|
for _, dynstring := range dynStrings(path, elf.DT_NEEDED) {
|
|
if dynstring == lib {
|
|
return
|
|
}
|
|
}
|
|
t.Errorf("%s is not linked to %s", path, lib)
|
|
}
|
|
|
|
func AssertHasRPath(t *testing.T, path, dir string) {
|
|
for _, tag := range []elf.DynTag{elf.DT_RPATH, elf.DT_RUNPATH} {
|
|
for _, dynstring := range dynStrings(path, tag) {
|
|
for _, rpath := range strings.Split(dynstring, ":") {
|
|
if filepath.Clean(rpath) == filepath.Clean(dir) {
|
|
return
|
|
}
|
|
}
|
|
}
|
|
}
|
|
t.Errorf("%s does not have rpath %s", path, dir)
|
|
}
|
|
|
|
// Build a trivial program that links against the shared runtime and check it runs.
|
|
func TestTrivialExecutable(t *testing.T) {
|
|
goCmd(t, "install", "-linkshared", "trivial")
|
|
run(t, "trivial executable", "./bin/trivial")
|
|
AssertIsLinkedTo(t, "./bin/trivial", soname)
|
|
AssertHasRPath(t, "./bin/trivial", gorootInstallDir)
|
|
}
|
|
|
|
// Build a GOPATH package into a shared library that links against the goroot runtime
|
|
// and an executable that links against both.
|
|
func TestGOPathShlib(t *testing.T) {
|
|
goCmd(t, "install", "-buildmode=shared", "-linkshared", "dep")
|
|
AssertIsLinkedTo(t, filepath.Join(gopathInstallDir, "libdep.so"), soname)
|
|
goCmd(t, "install", "-linkshared", "exe")
|
|
AssertIsLinkedTo(t, "./bin/exe", soname)
|
|
AssertIsLinkedTo(t, "./bin/exe", "libdep.so")
|
|
AssertHasRPath(t, "./bin/exe", gorootInstallDir)
|
|
AssertHasRPath(t, "./bin/exe", gopathInstallDir)
|
|
// And check it runs.
|
|
run(t, "executable linked to GOPATH library", "./bin/exe")
|
|
}
|
|
|
|
// The shared library contains a note listing the packages it contains in a section
|
|
// that is not mapped into memory.
|
|
func testPkgListNote(t *testing.T, f *elf.File, note *note) {
|
|
if note.section.Flags != 0 {
|
|
t.Errorf("package list section has flags %v", note.section.Flags)
|
|
}
|
|
if isOffsetLoaded(f, note.section.Offset) {
|
|
t.Errorf("package list section contained in PT_LOAD segment")
|
|
}
|
|
if note.desc != "dep\n" {
|
|
t.Errorf("incorrect package list %q", note.desc)
|
|
}
|
|
}
|
|
|
|
// The shared library contains a note containing the ABI hash that is mapped into
|
|
// memory and there is a local symbol called go.link.abihashbytes that points 16
|
|
// bytes into it.
|
|
func testABIHashNote(t *testing.T, f *elf.File, note *note) {
|
|
if note.section.Flags != elf.SHF_ALLOC {
|
|
t.Errorf("abi hash section has flags %v", note.section.Flags)
|
|
}
|
|
if !isOffsetLoaded(f, note.section.Offset) {
|
|
t.Errorf("abihash section not contained in PT_LOAD segment")
|
|
}
|
|
var hashbytes elf.Symbol
|
|
symbols, err := f.Symbols()
|
|
if err != nil {
|
|
t.Errorf("error reading symbols %v", err)
|
|
return
|
|
}
|
|
for _, sym := range symbols {
|
|
if sym.Name == "go.link.abihashbytes" {
|
|
hashbytes = sym
|
|
}
|
|
}
|
|
if hashbytes.Name == "" {
|
|
t.Errorf("no symbol called go.link.abihashbytes")
|
|
return
|
|
}
|
|
if elf.ST_BIND(hashbytes.Info) != elf.STB_LOCAL {
|
|
t.Errorf("%s has incorrect binding %v", hashbytes.Name, elf.ST_BIND(hashbytes.Info))
|
|
}
|
|
if f.Sections[hashbytes.Section] != note.section {
|
|
t.Errorf("%s has incorrect section %v", hashbytes.Name, f.Sections[hashbytes.Section].Name)
|
|
}
|
|
if hashbytes.Value-note.section.Addr != 16 {
|
|
t.Errorf("%s has incorrect offset into section %d", hashbytes.Name, hashbytes.Value-note.section.Addr)
|
|
}
|
|
}
|
|
|
|
// The shared library contains notes with defined contents; see above.
|
|
func TestNotes(t *testing.T) {
|
|
goCmd(t, "install", "-buildmode=shared", "-linkshared", "dep")
|
|
f, err := elf.Open(filepath.Join(gopathInstallDir, "libdep.so"))
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
defer f.Close()
|
|
notes, err := readNotes(f)
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
pkgListNoteFound := false
|
|
abiHashNoteFound := false
|
|
for _, note := range notes {
|
|
if note.name != "GO\x00\x00" {
|
|
continue
|
|
}
|
|
switch note.tag {
|
|
case 1: // ELF_NOTE_GOPKGLIST_TAG
|
|
if pkgListNoteFound {
|
|
t.Error("multiple package list notes")
|
|
}
|
|
testPkgListNote(t, f, note)
|
|
pkgListNoteFound = true
|
|
case 2: // ELF_NOTE_GOABIHASH_TAG
|
|
if abiHashNoteFound {
|
|
t.Error("multiple abi hash notes")
|
|
}
|
|
testABIHashNote(t, f, note)
|
|
abiHashNoteFound = true
|
|
}
|
|
}
|
|
if !pkgListNoteFound {
|
|
t.Error("package list note not found")
|
|
}
|
|
if !abiHashNoteFound {
|
|
t.Error("abi hash note not found")
|
|
}
|
|
}
|
|
|
|
// Testing rebuilding of shared libraries when they are stale is a bit more
|
|
// complicated that it seems like it should be. First, we make everything "old": but
|
|
// only a few seconds old, or it might be older than 6g (or the runtime source) and
|
|
// everything will get rebuilt. Then define a timestamp slightly newer than this
|
|
// time, which is what we set the mtime to of a file to cause it to be seen as new,
|
|
// and finally another slightly even newer one that we can compare files against to
|
|
// see if they have been rebuilt.
|
|
var oldTime = time.Now().Add(-9 * time.Second)
|
|
var nearlyNew = time.Now().Add(-6 * time.Second)
|
|
var stampTime = time.Now().Add(-3 * time.Second)
|
|
|
|
// resetFileStamps makes "everything" (bin, src, pkg from GOPATH and the
|
|
// test-specific parts of GOROOT) appear old.
|
|
func resetFileStamps() {
|
|
chtime := func(path string, info os.FileInfo, err error) error {
|
|
return os.Chtimes(path, oldTime, oldTime)
|
|
}
|
|
reset := func(path string) {
|
|
if err := filepath.Walk(path, chtime); err != nil {
|
|
log.Fatalf("resetFileStamps failed: %v", err)
|
|
}
|
|
|
|
}
|
|
reset("bin")
|
|
reset("pkg")
|
|
reset("src")
|
|
reset(gorootInstallDir)
|
|
}
|
|
|
|
// touch makes path newer than the "old" time stamp used by resetFileStamps.
|
|
func touch(path string) {
|
|
if err := os.Chtimes(path, nearlyNew, nearlyNew); err != nil {
|
|
log.Fatalf("os.Chtimes failed: %v", err)
|
|
}
|
|
}
|
|
|
|
// isNew returns if the path is newer than the time stamp used by touch.
|
|
func isNew(path string) bool {
|
|
fi, err := os.Stat(path)
|
|
if err != nil {
|
|
log.Fatalf("os.Stat failed: %v", err)
|
|
}
|
|
return fi.ModTime().After(stampTime)
|
|
}
|
|
|
|
// Fail unless path has been rebuilt (i.e. is newer than the time stamp used by
|
|
// isNew)
|
|
func AssertRebuilt(t *testing.T, msg, path string) {
|
|
if !isNew(path) {
|
|
t.Errorf("%s was not rebuilt (%s)", msg, path)
|
|
}
|
|
}
|
|
|
|
// Fail if path has been rebuilt (i.e. is newer than the time stamp used by isNew)
|
|
func AssertNotRebuilt(t *testing.T, msg, path string) {
|
|
if isNew(path) {
|
|
t.Errorf("%s was rebuilt (%s)", msg, path)
|
|
}
|
|
}
|
|
|
|
func TestRebuilding(t *testing.T) {
|
|
goCmd(t, "install", "-buildmode=shared", "-linkshared", "dep")
|
|
goCmd(t, "install", "-linkshared", "exe")
|
|
|
|
// If the source is newer than both the .a file and the .so, both are rebuilt.
|
|
resetFileStamps()
|
|
touch("src/dep/dep.go")
|
|
goCmd(t, "install", "-linkshared", "exe")
|
|
AssertRebuilt(t, "new source", filepath.Join(gopathInstallDir, "dep.a"))
|
|
AssertRebuilt(t, "new source", filepath.Join(gopathInstallDir, "libdep.so"))
|
|
|
|
// If the .a file is newer than the .so, the .so is rebuilt (but not the .a)
|
|
resetFileStamps()
|
|
touch(filepath.Join(gopathInstallDir, "dep.a"))
|
|
goCmd(t, "install", "-linkshared", "exe")
|
|
AssertNotRebuilt(t, "new .a file", filepath.Join(gopathInstallDir, "dep.a"))
|
|
AssertRebuilt(t, "new .a file", filepath.Join(gopathInstallDir, "libdep.so"))
|
|
}
|
|
|
|
func appendFile(path, content string) {
|
|
f, err := os.OpenFile(path, os.O_WRONLY|os.O_APPEND, 0660)
|
|
if err != nil {
|
|
log.Fatalf("os.OpenFile failed: %v", err)
|
|
}
|
|
defer func() {
|
|
err := f.Close()
|
|
if err != nil {
|
|
log.Fatalf("f.Close failed: %v", err)
|
|
}
|
|
}()
|
|
_, err = f.WriteString(content)
|
|
if err != nil {
|
|
log.Fatalf("f.WriteString failed: %v", err)
|
|
}
|
|
}
|
|
|
|
func TestABIChecking(t *testing.T) {
|
|
goCmd(t, "install", "-buildmode=shared", "-linkshared", "dep")
|
|
goCmd(t, "install", "-linkshared", "exe")
|
|
|
|
// If we make an ABI-breaking change to dep and rebuild libp.so but not exe,
|
|
// exe will abort with a complaint on startup.
|
|
// This assumes adding an exported function breaks ABI, which is not true in
|
|
// some senses but suffices for the narrow definition of ABI compatiblity the
|
|
// toolchain uses today.
|
|
appendFile("src/dep/dep.go", "func ABIBreak() {}\n")
|
|
goCmd(t, "install", "-buildmode=shared", "-linkshared", "dep")
|
|
c := exec.Command("./bin/exe")
|
|
output, err := c.CombinedOutput()
|
|
if err == nil {
|
|
t.Fatal("executing exe did not fail after ABI break")
|
|
}
|
|
scanner := bufio.NewScanner(bytes.NewReader(output))
|
|
foundMsg := false
|
|
const wantLine = "abi mismatch detected between the executable and libdep.so"
|
|
for scanner.Scan() {
|
|
if scanner.Text() == wantLine {
|
|
foundMsg = true
|
|
break
|
|
}
|
|
}
|
|
if err = scanner.Err(); err != nil {
|
|
t.Errorf("scanner encountered error: %v", err)
|
|
}
|
|
if !foundMsg {
|
|
t.Fatalf("exe failed, but without line %q; got output:\n%s", wantLine, output)
|
|
}
|
|
|
|
// Rebuilding exe makes it work again.
|
|
goCmd(t, "install", "-linkshared", "exe")
|
|
run(t, "rebuilt exe", "./bin/exe")
|
|
|
|
// If we make a change which does not break ABI (such as adding an unexported
|
|
// function) and rebuild libdep.so, exe still works.
|
|
appendFile("src/dep/dep.go", "func noABIBreak() {}\n")
|
|
goCmd(t, "install", "-buildmode=shared", "-linkshared", "dep")
|
|
run(t, "after non-ABI breaking change", "./bin/exe")
|
|
}
|