1
0
mirror of https://github.com/golang/go synced 2024-11-19 00:04:40 -07:00
go/src
Stefan Baebler 64cfe9fe22 net/url: improve url parsing error messages by quoting
Current implementation doesn't always make it obvious what the exact
problem with the URL is, so this makes it clearer by consistently quoting
the invalid URL, as is the norm in other parsing implementations, eg.:
strconv.Atoi(" 123") returns an error: parsing " 123": invalid syntax

Updates #29261

Change-Id: Icc6bff8b4a4584677c0f769992823e6e1e0d397d
GitHub-Last-Rev: 648b9d93fe
GitHub-Pull-Request: golang/go#29384
Reviewed-on: https://go-review.googlesource.com/c/go/+/185117
Reviewed-by: Daniel Martí <mvdan@mvdan.cc>
Run-TryBot: Daniel Martí <mvdan@mvdan.cc>
TryBot-Result: Gobot Gobot <gobot@golang.org>
2019-08-28 12:47:06 +00:00
..
archive archive/zip: remove unused special case 2019-08-27 17:00:43 +00:00
bufio bufio: fix ExampleScanner_Bytes comment, add error check 2019-06-25 00:29:24 +00:00
builtin builtin: spec correction for panic() 2019-04-05 00:52:55 +00:00
bytes bytes: remove obsolete comment 2019-05-28 02:52:39 +00:00
cmd cmd/compile: remove gc.eqtype in comments 2019-08-28 09:28:59 +00:00
compress compress/gzip: add missing error check in test 2019-05-24 14:55:39 +00:00
container all: shorten some tests 2019-05-22 12:54:00 +00:00
context all: remove os.ErrTimeout 2019-08-02 17:57:18 +00:00
crypto crypto/tls: remove TLS 1.3 opt-out 2019-08-27 22:25:08 +00:00
database/sql database/sql: add support for decimal interface 2019-06-13 16:59:01 +00:00
debug debug/elf: add version information to all dynamic symbols 2019-07-05 18:18:26 +00:00
encoding encoding/xml: rename fInnerXml to fInnerXML 2019-08-28 10:21:40 +00:00
errors errors: document Is and As methods 2019-08-27 16:51:42 +00:00
expvar all: change some function documentation to be more idiomatic 2019-07-28 18:09:57 +00:00
flag
fmt doc/go1.13: document fmt's number syntax updates 2019-08-23 23:40:29 +00:00
go go/types: process each segment of delayed actions in FIFO order 2019-08-26 17:14:41 +00:00
hash
html html/template: micro optimization for isJSType 2019-08-27 17:41:33 +00:00
image image/png: hoist repetitive pixels per byte out of loop in Encode 2019-08-28 09:02:35 +00:00
index/suffixarray index/suffixarray: index 3-10X faster in half the memory 2019-05-13 18:50:32 +00:00
internal reflect: optimize directlyAssignable to avoid rtype.Name call 2019-08-27 16:44:22 +00:00
io
log
math cmd/gofmt: fix normalization of imaginary number literals 2019-06-21 17:24:29 +00:00
mime mime: encode CTL and non-US-ASCII characters in FormatMediaType 2019-05-23 15:45:00 +00:00
net net/url: improve url parsing error messages by quoting 2019-08-28 12:47:06 +00:00
os os: change Readdirnames doc to follow that of Readdir 2019-08-02 21:52:01 +00:00
path path: fix mismatch between error message and corresponding test function 2019-08-08 00:38:10 +00:00
plugin
reflect reflect: optimize directlyAssignable to avoid rtype.Name call 2019-08-27 16:44:22 +00:00
regexp regexp/syntax: exclude full range from String negation case 2019-05-22 04:43:25 +00:00
runtime runtime: reduce allocations when building pprof LabelSet 2019-08-28 10:43:11 +00:00
sort
strconv strconv: Speed improvement to number parsing 2019-08-28 03:23:59 +00:00
strings strings: clarify usage of Title and ToTitle 2019-07-30 02:52:57 +00:00
sync sync: document implementation of Once.Do 2019-07-01 14:45:49 +00:00
syscall runtime,syscall/js: reuse wasm memory DataView 2019-08-28 05:11:20 +00:00
testdata
testing Revert "cmd/go: move automatic testing.Init call into generated test code" 2019-07-22 21:42:51 +00:00
text text/template: avoid allocating a new common in copy 2019-08-27 16:56:26 +00:00
time time: update TestSub to avoid future regressions 2019-08-16 19:54:57 +00:00
unicode
unsafe
vendor net/http: update bundled golang.org/x/net/http2 to import security fix 2019-08-23 17:03:17 +00:00
all.bash
all.bat
all.rc
bootstrap.bash
buildall.bash cmd/go: run full 'go vet' during 'go test' for packages in GOROOT 2019-05-16 03:24:56 +00:00
clean.bash
clean.bat
clean.rc
cmp.bash
go.mod net/http: update bundled golang.org/x/net/http2 to import security fix 2019-08-23 17:03:17 +00:00
go.sum net/http: update bundled golang.org/x/net/http2 to import security fix 2019-08-23 17:03:17 +00:00
iostest.bash
make.bash
make.bat
Make.dist
make.rc
naclmake.bash
nacltest.bash
race.bash
race.bat
README.vendor all: update 'go get' command in standard library README.vendor 2019-08-23 21:07:49 +00:00
run.bash cmd/dist: allow builders to control granularity of test/ directory sharding 2019-05-06 23:02:29 +00:00
run.bat
run.rc

Vendoring in std and cmd
========================

The Go command maintains copies of external packages needed by the
standard library in the src/vendor and src/cmd/vendor directories.

In GOPATH mode, imports of vendored packages are resolved to these
directories following normal vendor directory logic
(see golang.org/s/go15vendor).

In module mode, std and cmd are modules (defined in src/go.mod and
src/cmd/go.mod). When a package outside std or cmd is imported
by a package inside std or cmd, the import path is interpreted
as if it had a "vendor/" prefix. For example, within "crypto/tls",
an import of "golang.org/x/crypto/cryptobyte" resolves to
"vendor/golang.org/x/crypto/cryptobyte". When a package with the
same path is imported from a package outside std or cmd, it will
be resolved normally. Consequently, a binary may be built with two
copies of a package at different versions if the package is
imported normally and vendored by the standard library.

Vendored packages are internally renamed with a "vendor/" prefix
to preserve the invariant that all packages have distinct paths.
This is necessary to avoid compiler and linker conflicts. Adding
a "vendor/" prefix also maintains the invariant that standard
library packages begin with a dotless path element.

The module requirements of std and cmd do not influence version
selection in other modules. They are only considered when running
module commands like 'go get' and 'go mod vendor' from a directory
in GOROOT/src.

Maintaining vendor directories
==============================

Before updating vendor directories, ensure that module mode is enabled.
Make sure GO111MODULE=off is not set ('on' or 'auto' should work).

Requirements may be added, updated, and removed with 'go get'.
The vendor directory may be updated with 'go mod vendor'.
A typical sequence might be:

    cd src
    go get -d golang.org/x/net@latest
    go mod tidy
    go mod vendor

Use caution when passing '-u' to 'go get'. The '-u' flag updates
modules providing all transitively imported packages, not only
the module providing the target package.

Note that 'go mod vendor' only copies packages that are transitively
imported by packages in the current module. If a new package is needed,
it should be imported before running 'go mod vendor'.