mirror of
https://github.com/golang/go
synced 2024-11-19 00:54:42 -07:00
87ced824bd
Motivation: Previously, we assumed that the set of types for which a complete method set (containing all synthesized wrapper functions) is required at runtime was the set of types used as operands to some *ssa.MakeInterface instruction. In fact, this is an underapproximation because types can be derived from other ones via reflection, and some of these may need methods. The reflect.Type API allows *T to be derived from T, and these may have different method sets. Reflection also allows almost any subcomponent of a type to be accessed (with one exception: given T, defined 'type T struct{S}', you can reach S but not struct{S}). As a result, the pointer analysis was unable to generate all necessary constraints before running the solver, causing a crash when reflection derives types whose methods are unavailable. (A similar problem would afflict an ahead-of-time compiler based on ssa. The ssa/interp interpreter was immune only because it does not require all wrapper methods to be created before execution begins.) Description: This change causes the SSA builder to record, for each package, the set of all types with non-empty method sets that are referenced within that package. This set is accessed via Packages.TypesWithMethodSets(). Program.TypesWithMethodSets() returns its union across all packages. The set of references that matter are: - types of operands to some MakeInterface instruction (as before) - types of all exported package members - all subcomponents of the above, recursively. This is a conservative approximation to the set of types whose methods may be called dynamically. We define the owning package of a type as follows: - the owner of a named type is the package in which it is defined; - the owner of a pointer-to-named type is the owner of that named type; - the owner of all other types is nil. A package must include the method sets for all types that it owns, and all subcomponents of that type that are not owned by another package, recursively. Types with an owner appear in exactly one package; types with no owner (such as struct{T}) may appear within multiple packages. (A typical Go compiler would emit multiple copies of these methods as weak symbols; a typical linker would eliminate duplicates.) Also: - go/types/typemap: implement hash function for *Tuple. - pointer: generate nodes/constraints for all of ssa.Program.TypesWithMethodSets(). Add rtti.go regression test. - Add API test of Package.TypesWithMethodSets(). - Set Function.Pkg to nil (again) for wrapper functions, since these may be shared by many packages. - Remove a redundant logging statement. - Document that ssa CREATE phase is in fact sequential. Fixes golang/go#6605 R=gri CC=golang-dev https://golang.org/cl/14920056
229 lines
6.6 KiB
Go
229 lines
6.6 KiB
Go
// Copyright 2013 The Go Authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style
|
|
// license that can be found in the LICENSE file.
|
|
|
|
package ssa_test
|
|
|
|
import (
|
|
"go/parser"
|
|
"reflect"
|
|
"sort"
|
|
"strings"
|
|
"testing"
|
|
|
|
"code.google.com/p/go.tools/go/types"
|
|
"code.google.com/p/go.tools/importer"
|
|
"code.google.com/p/go.tools/ssa"
|
|
)
|
|
|
|
func isEmpty(f *ssa.Function) bool { return f.Blocks == nil }
|
|
|
|
// Tests that programs partially loaded from gc object files contain
|
|
// functions with no code for the external portions, but are otherwise ok.
|
|
func TestExternalPackages(t *testing.T) {
|
|
test := `
|
|
package main
|
|
|
|
import (
|
|
"bytes"
|
|
"io"
|
|
"testing"
|
|
)
|
|
|
|
func main() {
|
|
var t testing.T
|
|
t.Parallel() // static call to external declared method
|
|
t.Fail() // static call to promoted external declared method
|
|
testing.Short() // static call to external package-level function
|
|
|
|
var w io.Writer = new(bytes.Buffer)
|
|
w.Write(nil) // interface invoke of external declared method
|
|
}
|
|
`
|
|
imp := importer.New(new(importer.Config)) // no go/build.Context; uses GC importer
|
|
|
|
f, err := parser.ParseFile(imp.Fset, "<input>", test, 0)
|
|
if err != nil {
|
|
t.Error(err)
|
|
return
|
|
}
|
|
|
|
mainInfo := imp.CreatePackage("main", f)
|
|
|
|
prog := ssa.NewProgram(imp.Fset, ssa.SanityCheckFunctions)
|
|
if err := prog.CreatePackages(imp); err != nil {
|
|
t.Error(err)
|
|
return
|
|
}
|
|
mainPkg := prog.Package(mainInfo.Pkg)
|
|
mainPkg.Build()
|
|
|
|
// Only the main package and its immediate dependencies are loaded.
|
|
deps := []string{"bytes", "io", "testing"}
|
|
all := prog.AllPackages()
|
|
if len(all) != 1+len(deps) {
|
|
t.Errorf("unexpected set of loaded packages: %q", all)
|
|
}
|
|
for _, path := range deps {
|
|
pkg := prog.ImportedPackage(path)
|
|
if pkg == nil {
|
|
t.Errorf("package not loaded: %q", path)
|
|
continue
|
|
}
|
|
|
|
// External packages should have no function bodies (except for wrappers).
|
|
isExt := pkg != mainPkg
|
|
|
|
// init()
|
|
if isExt && !isEmpty(pkg.Func("init")) {
|
|
t.Errorf("external package %s has non-empty init", pkg)
|
|
} else if !isExt && isEmpty(pkg.Func("init")) {
|
|
t.Errorf("main package %s has empty init", pkg)
|
|
}
|
|
|
|
for _, mem := range pkg.Members {
|
|
switch mem := mem.(type) {
|
|
case *ssa.Function:
|
|
// Functions at package level.
|
|
if isExt && !isEmpty(mem) {
|
|
t.Errorf("external function %s is non-empty", mem)
|
|
} else if !isExt && isEmpty(mem) {
|
|
t.Errorf("function %s is empty", mem)
|
|
}
|
|
|
|
case *ssa.Type:
|
|
// Methods of named types T.
|
|
// (In this test, all exported methods belong to *T not T.)
|
|
if !isExt {
|
|
t.Fatalf("unexpected name type in main package: %s", mem)
|
|
}
|
|
mset := types.NewPointer(mem.Type()).MethodSet()
|
|
for i, n := 0, mset.Len(); i < n; i++ {
|
|
m := prog.Method(mset.At(i))
|
|
// For external types, only synthetic wrappers have code.
|
|
expExt := !strings.Contains(m.Synthetic, "wrapper")
|
|
if expExt && !isEmpty(m) {
|
|
t.Errorf("external method %s is non-empty: %s",
|
|
m, m.Synthetic)
|
|
} else if !expExt && isEmpty(m) {
|
|
t.Errorf("method function %s is empty: %s",
|
|
m, m.Synthetic)
|
|
}
|
|
}
|
|
}
|
|
}
|
|
}
|
|
|
|
expectedCallee := []string{
|
|
"(*testing.T).Parallel",
|
|
"(*testing.common).Fail",
|
|
"testing.Short",
|
|
"N/A",
|
|
}
|
|
callNum := 0
|
|
for _, b := range mainPkg.Func("main").Blocks {
|
|
for _, instr := range b.Instrs {
|
|
switch instr := instr.(type) {
|
|
case ssa.CallInstruction:
|
|
call := instr.Common()
|
|
if want := expectedCallee[callNum]; want != "N/A" {
|
|
got := call.StaticCallee().String()
|
|
if want != got {
|
|
t.Errorf("call #%d from main.main: got callee %s, want %s",
|
|
callNum, got, want)
|
|
}
|
|
}
|
|
callNum++
|
|
}
|
|
}
|
|
}
|
|
if callNum != 4 {
|
|
t.Errorf("in main.main: got %d calls, want %d", callNum, 4)
|
|
}
|
|
}
|
|
|
|
// TestMethodSets tests that Package.TypesWithMethodSets includes all necessary types.
|
|
func TestTypesWithMethodSets(t *testing.T) {
|
|
tests := []struct {
|
|
input string
|
|
want []string
|
|
}{
|
|
// An exported package-level type is needed.
|
|
{`package p; type T struct{}; func (T) f() {}`,
|
|
[]string{"*p.T", "p.T"},
|
|
},
|
|
// An unexported package-level type is not needed.
|
|
{`package p; type t struct{}; func (t) f() {}`,
|
|
nil,
|
|
},
|
|
// Subcomponents of type of exported package-level var are needed.
|
|
{`package p; import "bytes"; var V struct {*bytes.Buffer}`,
|
|
[]string{"struct{*bytes.Buffer}"},
|
|
},
|
|
// Subcomponents of type of unexported package-level var are not needed.
|
|
{`package p; import "bytes"; var v struct {*bytes.Buffer}`,
|
|
nil,
|
|
},
|
|
// Subcomponents of type of exported package-level function are needed.
|
|
{`package p; import "bytes"; func F(struct {*bytes.Buffer}) {}`,
|
|
[]string{"struct{*bytes.Buffer}"},
|
|
},
|
|
// Subcomponents of type of unexported package-level function are not needed.
|
|
{`package p; import "bytes"; func f(struct {*bytes.Buffer}) {}`,
|
|
nil,
|
|
},
|
|
// Subcomponents of type of exported method are needed.
|
|
{`package p; import "bytes"; type x struct{}; func (x) G(struct {*bytes.Buffer}) {}`,
|
|
[]string{"*p.x", "p.x", "struct{*bytes.Buffer}"},
|
|
},
|
|
// Subcomponents of type of unexported method are not needed.
|
|
{`package p; import "bytes"; type X struct{}; func (X) G(struct {*bytes.Buffer}) {}`,
|
|
[]string{"*p.X", "p.X", "struct{*bytes.Buffer}"},
|
|
},
|
|
// Local types aren't needed.
|
|
{`package p; import "bytes"; func f() { type T struct {*bytes.Buffer}; var t T; _ = t }`,
|
|
nil,
|
|
},
|
|
// ...unless used by MakeInterface.
|
|
{`package p; import "bytes"; func f() { type T struct {*bytes.Buffer}; _ = interface{}(T{}) }`,
|
|
[]string{"*p.T", "p.T"},
|
|
},
|
|
// Types used as operand of MakeInterface are needed.
|
|
{`package p; import "bytes"; func f() { _ = interface{}(struct{*bytes.Buffer}{}) }`,
|
|
[]string{"struct{*bytes.Buffer}"},
|
|
},
|
|
// MakeInterface is optimized away when storing to a blank.
|
|
{`package p; import "bytes"; var _ interface{} = struct{*bytes.Buffer}{}`,
|
|
nil,
|
|
},
|
|
}
|
|
for i, test := range tests {
|
|
imp := importer.New(new(importer.Config)) // no go/build.Context; uses GC importer
|
|
|
|
f, err := parser.ParseFile(imp.Fset, "<input>", test.input, 0)
|
|
if err != nil {
|
|
t.Errorf("test %d: %s", i, err)
|
|
continue
|
|
}
|
|
|
|
mainInfo := imp.CreatePackage("p", f)
|
|
prog := ssa.NewProgram(imp.Fset, ssa.SanityCheckFunctions)
|
|
if err := prog.CreatePackages(imp); err != nil {
|
|
t.Errorf("test %d: %s", i, err)
|
|
continue
|
|
}
|
|
mainPkg := prog.Package(mainInfo.Pkg)
|
|
prog.BuildAll()
|
|
|
|
var typstrs []string
|
|
for _, T := range mainPkg.TypesWithMethodSets() {
|
|
typstrs = append(typstrs, T.String())
|
|
}
|
|
sort.Strings(typstrs)
|
|
|
|
if !reflect.DeepEqual(typstrs, test.want) {
|
|
t.Errorf("test %d: got %q, want %q", i, typstrs, test.want)
|
|
}
|
|
}
|
|
}
|