mirror of
https://github.com/golang/go
synced 2024-10-01 11:38:34 -06:00
dbc83e6dc0
typeIsValid() intended to stop on a named type, but since we called Underlying(), switch case never caught any named type. To avoid that, do an early check. Fixes golang/go#36637 Change-Id: I2700afbb8f9678b4542e2e7dccc3be59b1d9ebdf Reviewed-on: https://go-review.googlesource.com/c/tools/+/215238 Run-TryBot: Rebecca Stambler <rstambler@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Rebecca Stambler <rstambler@golang.org>
34 lines
2.2 KiB
Go
34 lines
2.2 KiB
Go
// +build go1.11
|
|
|
|
package bad
|
|
|
|
// See #36637
|
|
type stateFunc func() stateFunc //@item(stateFunc, "stateFunc", "func() stateFunc", "type")
|
|
|
|
var a unknown //@item(global_a, "a", "unknown", "var"),diag("unknown", "compiler", "undeclared name: unknown")
|
|
|
|
func random() int { //@item(random, "random", "func() int", "func")
|
|
//@complete("", global_a, bob, random, random2, random3, stateFunc, stuff)
|
|
return 0
|
|
}
|
|
|
|
func random2(y int) int { //@item(random2, "random2", "func(y int) int", "func"),item(bad_y_param, "y", "int", "var")
|
|
x := 6 //@item(x, "x", "int", "var"),diag("x", "compiler", "x declared but not used")
|
|
var q blah //@item(q, "q", "blah", "var"),diag("q", "compiler", "q declared but not used"),diag("blah", "compiler", "undeclared name: blah")
|
|
var t **blob //@item(t, "t", "**blob", "var"),diag("t", "compiler", "t declared but not used"),diag("blob", "compiler", "undeclared name: blob")
|
|
//@complete("", q, t, x, bad_y_param, global_a, bob, random, random2, random3, stateFunc, stuff)
|
|
|
|
return y
|
|
}
|
|
|
|
func random3(y ...int) { //@item(random3, "random3", "func(y ...int)", "func"),item(y_variadic_param, "y", "[]int", "var")
|
|
//@complete("", y_variadic_param, global_a, bob, random, random2, random3, stateFunc, stuff)
|
|
|
|
var ch chan (favType1) //@item(ch, "ch", "chan (favType1)", "var"),diag("ch", "compiler", "ch declared but not used"),diag("favType1", "compiler", "undeclared name: favType1")
|
|
var m map[keyType]int //@item(m, "m", "map[keyType]int", "var"),diag("m", "compiler", "m declared but not used"),diag("keyType", "compiler", "undeclared name: keyType")
|
|
var arr []favType2 //@item(arr, "arr", "[]favType2", "var"),diag("arr", "compiler", "arr declared but not used"),diag("favType2", "compiler", "undeclared name: favType2")
|
|
var fn1 func() badResult //@item(fn1, "fn1", "func() badResult", "var"),diag("fn1", "compiler", "fn1 declared but not used"),diag("badResult", "compiler", "undeclared name: badResult")
|
|
var fn2 func(badParam) //@item(fn2, "fn2", "func(badParam)", "var"),diag("fn2", "compiler", "fn2 declared but not used"),diag("badParam", "compiler", "undeclared name: badParam")
|
|
//@complete("", arr, ch, fn1, fn2, m, y_variadic_param, global_a, bob, random, random2, random3, stateFunc, stuff)
|
|
}
|