Muir Manders 613a0345a2 internal/lsp/source: optimize enumeration of a type's fields ... When searching for deep completions, we can end up enumerating struct types' fields a lot. Optimize fieldSelections to reduce work: - Wait until we see an embedded field before we create the "seen" map. - Use a callback style to iterate over the struct's fields rather than returning a slice of fields. - Change "seen" checking strategy back to track struct types rather than each individual field. Struct with 5 non-embedded fields: name old time/op new time/op delta Fields-16 293ns ± 1% 20ns ± 2% -93.13% (p=0.008 n=5+5) name old alloc/op new alloc/op delta Fields-16 120B ± 0% 0B -100.00% (p=0.008 n=5+5) name old allocs/op new allocs/op delta Fields-16 4.00 ± 0% 0.00 -100.00% (p=0.008 n=5+5) Same struct but add an embedded struct with 2 fields: name old time/op new time/op delta Fields-16 389ns ± 1% 142ns ± 1% -63.53% (p=0.008 n=5+5) name old alloc/op new alloc/op delta Fields-16 120B ± 0% 144B ± 0% +20.00% (p=0.008 n=5+5) name old allocs/op new allocs/op delta Fields-16 4.00 ± 0% 2.00 ± 0% -50.00% (p=0.008 n=5+5) I think the alloc/op went up because the "seen" map is no longer allocated on the stack. There is more room for more optimization, but it's probably not worth making things more complicated. Change-Id: I6f9f2124334a8594ef9d6f9b5ac4b3a8aead5f49 Reviewed-on: https://go-review.googlesource.com/c/tools/+/223419 Run-TryBot: Muir Manders <muir@mnd.rs> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Rebecca Stambler <rstambler@golang.org>		2020-03-18 05:47:12 +00:00
..
code_lens.go	x/tools/gopls: run go generate through CodeLens	2020-03-17 04:34:34 +00:00
comment_test.go	internal/lsp: convert comments to markdown before sending to client	2019-10-04 18:35:38 +00:00
comment.go	internal/lsp: convert comments to markdown before sending to client	2019-10-04 18:35:38 +00:00
completion_builtin.go	internal/lsp/source: untangle completion type comparison	2020-02-24 18:12:40 +00:00
completion_format.go	internal/lsp: migrate telemetry to using the event package	2020-03-12 03:59:16 +00:00
completion_keywords.go	internal/lsp/source: offer loop keyword completions in range stmt	2020-03-12 04:57:24 +00:00
completion_labels.go	internal/lsp: sort by label after score	2019-12-30 21:11:21 +00:00
completion_literal.go	internal/lsp: migrate telemetry to using the event package	2020-03-12 03:59:16 +00:00
completion_snippet.go	internal/lsp: merge completion options into source.Options	2020-01-13 20:09:44 +00:00
completion_statements.go	internal/lsp/source: offer completion "if err != nil { return err }"	2020-03-10 21:06:53 +00:00
completion.go	internal/lsp/source: optimize enumeration of a type's fields	2020-03-18 05:47:12 +00:00
deep_completion.go	internal/lsp/source: improve completion involving multiple return values	2020-02-06 05:07:08 +00:00
diagnostics.go	internal/lsp: migrate telemetry to using the event package	2020-03-12 03:59:16 +00:00
folding_range.go	internal/lsp/cache: add file contents to ParseGoHandle	2020-02-13 05:05:14 +00:00
format_test.go	internal/lsp/source: trim file very carefully	2020-01-17 20:34:13 +00:00
format.go	internal/lsp: migrate telemetry to using the event package	2020-03-12 03:59:16 +00:00
highlight.go	internal/lsp: migrate telemetry to using the event package	2020-03-12 03:59:16 +00:00
hover.go	internal/lsp: migrate telemetry to using the event package	2020-03-12 03:59:16 +00:00
identifier.go	internal/lsp: migrate telemetry to using the event package	2020-03-12 03:59:16 +00:00
implementation.go	internal/lsp: migrate telemetry to using the event package	2020-03-12 03:59:16 +00:00
options.go	x/tools/gopls: run go generate through CodeLens	2020-03-17 04:34:34 +00:00
references.go	internal/lsp: migrate telemetry to using the event package	2020-03-12 03:59:16 +00:00
rename_check.go	internal/lsp: improve literal func completion candidates	2019-11-07 21:18:00 +00:00
rename.go	internal/lsp: migrate telemetry to using the event package	2020-03-12 03:59:16 +00:00
signature_help.go	internal/lsp: migrate telemetry to using the event package	2020-03-12 03:59:16 +00:00
source_test.go	x/tools/gopls: run go generate through CodeLens	2020-03-17 04:34:34 +00:00
symbols.go	internal/lsp: fix breadcrumbs when inside of a method	2020-03-17 19:04:34 +00:00
util.go	internal/lsp/source: optimize enumeration of a type's fields	2020-03-18 05:47:12 +00:00
view.go	internal/lsp/cache: include session IDs in some cache keys	2020-03-05 20:50:14 +00:00
workspace_symbol.go	internal/lsp: migrate telemetry to using the event package	2020-03-12 03:59:16 +00:00