Ian Cottrell eff45d17df internal/telemetry: convert key from string to struct ... This makes keys a pointer, which reduces the allocations during logging, and has a significant improvement in memory and cpu cost when there is no exporter. Packing a string into an interface requires a 16 byte allocation, packing a pointer does not. name old time/op new time/op delta /LogNoExporter-8 4.39µs ± 2% 3.83µs ± 2% -12.74% (p=0.000 n=18+20) /Log-8 23.5µs ± 2% 22.6µs ± 1% -4.20% (p=0.000 n=19+18) name old alloc/op new alloc/op delta /LogNoExporter-8 1.70kB ± 0% 1.38kB ± 0% -18.78% (p=0.000 n=20+20) /Log-8 4.91kB ± 0% 4.91kB ± 0% ~ (p=1.000 n=20+20) name old allocs/op new allocs/op delta /LogNoExporter-8 83.0 ± 0% 63.0 ± 0% -24.10% (p=0.000 n=20+20) /Log-8 163 ± 0% 163 ± 0% ~ (all equal) Change-Id: Iec127f1bff8d5c8f4bd0a6d9f6d8fc4b8bc740b2 Reviewed-on: https://go-review.googlesource.com/c/tools/+/222599 Run-TryBot: Ian Cottrell <iancottrell@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Robert Findley <rfindley@google.com>		2020-03-12 04:17:52 +00:00
..
info.1.11.go	internal/lsp/debug: add newlines to debug messages	2019-06-12 17:36:44 +00:00
info.1.12.go	internal/lsp/debug: add newlines to debug messages	2019-06-12 17:36:44 +00:00
info.go	internal/lsp: change debug instance to a struct	2020-02-07 11:26:02 +00:00
metrics.go	internal/telemetry: convert key from string to struct	2020-03-12 04:17:52 +00:00
rpc.go	internal/lsp: migrate telemetry to using the event package	2020-03-12 03:59:16 +00:00
serve_test.go	internal/lsp/debug: move all debug state onto the Instance	2020-02-24 22:50:47 +00:00
serve.go	internal/lsp: migrate telemetry to using the event package	2020-03-12 03:59:16 +00:00
trace.go	internal/lsp: migrate telemetry to using the event package	2020-03-12 03:59:16 +00:00