1
0
mirror of https://github.com/golang/go synced 2024-09-30 22:48:32 -06:00
go/internal/lsp/cache
Heschi Kreinick 60da08ac03 internal/lsp/cache: remove files from the memoize.Store
The memoize cache buys us little for files: the cache value is not
really a function of the inputs, but rather the filesystem state. It's
pretty much just as easy to manage them explicitly, and it's a start at
simplifying our caching strategy.

We do lose one small feature: if we try to read the same file
concurrently, reads will not be deduplicated. I suspect that doesn't
matter.

Change-Id: I75e219467fb7a512d9cfdf87443d012c85f03df9
Reviewed-on: https://go-review.googlesource.com/c/tools/+/243197
Reviewed-by: Rebecca Stambler <rstambler@golang.org>
Reviewed-by: Robert Findley <rfindley@google.com>
2020-07-28 17:34:34 +00:00
..
analysis.go internal/memoize: add an error return to (*handle).Get 2020-06-24 16:33:19 +00:00
cache.go internal/lsp/cache: remove files from the memoize.Store 2020-07-28 17:34:34 +00:00
check.go internal/lsp: minimize PackageHandle interface 2020-07-28 17:34:24 +00:00
error_test.go internal/lsp: refactor error handling code in type-checking 2019-10-21 18:57:46 +00:00
errors.go internal/lsp: add parse errors as diagnostics even when parsing fails 2020-07-24 17:29:32 +00:00
keys.go internal/lsp: decouple client and server debug 2020-06-11 13:49:48 +00:00
load.go internal/lsp: treat the module root as the workspace root, if available 2020-07-23 21:33:49 +00:00
mod_tidy.go internal/lsp: add errors for missing modules that don't map to an import 2020-07-24 00:18:24 +00:00
mod.go internal/lsp: correctly marshal arguments for upgrade code lens 2020-07-27 21:52:59 +00:00
os_darwin.go internal/lsp: add a mutex around the view's options 2020-04-02 16:41:49 +00:00
os_windows.go internal/lsp/cache: validate workspace path case 2020-03-27 19:55:53 +00:00
parse.go internal/lsp: minimize PackageHandle interface 2020-07-28 17:34:24 +00:00
pkg.go internal/lsp: minimize PackageHandle interface 2020-07-28 17:34:24 +00:00
session.go internal/lsp: handle unknown revision in go.mod file 2020-07-21 21:40:18 +00:00
snapshot.go internal/lsp: minimize PackageHandle interface 2020-07-28 17:34:24 +00:00
view_test.go internal/lsp/cache: validate workspace path case 2020-03-27 19:55:53 +00:00
view.go internal/lsp: treat the module root as the workspace root, if available 2020-07-23 21:33:49 +00:00