5f5c018ca4
The current mknode has a few problems: 1) It tends not to run successfully if the tree is in a broken state. 2) It requires that it be run by the go tool in the tree (somewhat related to 1) 3) It requires setting GOROOT 4) It imports code outside the tree (x/packages) This makes mknode.go very fragile. In particular, I've spent lots of time fighting mknode when adding or removing code, related to 1. Rewrite to just use go/ast and friends. No typechecking, no importing, etc. It can run with any go version, it doesn't need to be the one corresponding to the code in which it is run. (e.g. you can use go 1.16 to run mknode). It will work as long as the ir package is parseable. When run, it generates identical output to the old mknode. Fixes #53959 Change-Id: I5ce0b55572ebcd2fcd11af57a5f29bbf9fa4ed33 Reviewed-on: https://go-review.googlesource.com/c/go/+/418375 Run-TryBot: Keith Randall <khr@golang.org> Reviewed-by: Matthew Dempsky <mdempsky@google.com> TryBot-Result: Gopher Robot <gobot@golang.org> Reviewed-by: Heschi Kreinick <heschi@google.com> |
||
|---|---|---|
| .github | ||
| api | ||
| doc | ||
| lib/time | ||
| misc | ||
| src | ||
| test | ||
| .gitattributes | ||
| .gitignore | ||
| codereview.cfg | ||
| CONTRIBUTING.md | ||
| LICENSE | ||
| PATENTS | ||
| README.md | ||
| SECURITY.md | ||
The Go Programming Language
Go is an open source programming language that makes it easy to build simple, reliable, and efficient software.
Gopher image by Renee French, licensed under Creative Commons 3.0 Attributions license.
Our canonical Git repository is located at https://go.googlesource.com/go. There is a mirror of the repository at https://github.com/golang/go.
Unless otherwise noted, the Go source files are distributed under the BSD-style license found in the LICENSE file.
Download and Install
Binary Distributions
Official binary distributions are available at https://go.dev/dl/.
After downloading a binary release, visit https://go.dev/doc/install for installation instructions.
Install From Source
If a binary distribution is not available for your combination of operating system and architecture, visit https://go.dev/doc/install/source for source installation instructions.
Contributing
Go is the work of thousands of contributors. We appreciate your help!
To contribute, please read the contribution guidelines at https://go.dev/doc/contribute.
Note that the Go project uses the issue tracker for bug reports and proposals only. See https://go.dev/wiki/Questions for a list of places to ask questions about the Go language.