1
0
mirror of https://github.com/golang/go synced 2024-10-01 04:18:33 -06:00
go/internal/lsp/source
Muir Manders 5e3480f0e0 internal/lsp: start handling watched file deletes
Now when a file is deleted we force the file's packages to refresh
go/packages metadata, and kick off diagnostics.

I made a couple other changes to watched file handling:
- Kick off diagnostics in a goroutine to match how DidChange works.
  This will allow us to work through big sets of file changes faster,
  and will save duplicated work once type checking can be canceled.
- Don't assume a watched file is only part of one view.

Two interesting cases we don't handle yet:
- If the deleted file was the only file in the package, we don't
  currently update diagnostics for dependent packages. This requires
  rejiggering how diagnostics are invoked a bit.
- If the deleted file is still open in the editor and then later
  closed, we don't trigger metadata/diagnostics refresh on DidClose.

Updates golang/go#31553

Change-Id: I65768614c24d9800ffea149ccdbdbd3cb7b2f3d8
Reviewed-on: https://go-review.googlesource.com/c/tools/+/193121
Run-TryBot: Rebecca Stambler <rstambler@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Ian Cottrell <iancottrell@google.com>
2019-09-10 20:08:16 +00:00
..
analysis.go go/analysis: handle common nil pointers 2019-08-24 21:01:00 +00:00
completion_format.go internal/lsp: derive ASTs from type information 2019-09-10 13:53:09 +00:00
completion_snippet.go internal/lsp: simplify snippet config/generation 2019-09-10 04:45:52 +00:00
completion.go internal/lsp: derive ASTs from type information 2019-09-10 13:53:09 +00:00
deep_completion.go internal/lsp: limit deep completion search scope 2019-08-27 20:50:25 +00:00
diagnostics_test.go internal/span: change URI.Filename so it just returns the filename 2019-06-10 21:39:43 +00:00
diagnostics.go internal/lsp: enable suggested fixes by default 2019-09-09 19:40:07 +00:00
enums.go internal/lsp: switch to using protocol positions for document symbols 2019-09-06 18:11:17 +00:00
folding_range.go internal/lsp: remove the GetToken and GetAST functions 2019-09-09 18:10:35 +00:00
format.go internal/lsp: remove the GetToken and GetAST functions 2019-09-09 18:10:35 +00:00
highlight.go internal/lsp: switch to using protocol positions for document symbols 2019-09-06 18:11:17 +00:00
hover.go internal/lsp: remove the GetToken and GetAST functions 2019-09-09 18:10:35 +00:00
identifier.go internal/lsp: derive ASTs from type information 2019-09-10 13:53:09 +00:00
imports_test.go internal/lsp: abstract the diff library so it can be substituted 2019-08-20 03:37:07 +00:00
imports.go internal/lsp: abstract the diff library so it can be substituted 2019-08-20 03:37:07 +00:00
options.go internal/lsp: only build a view when we have its configuration 2019-09-10 14:40:41 +00:00
references.go internal/lsp: derive ASTs from type information 2019-09-10 13:53:09 +00:00
rename_check.go internal/lsp: use memoize package to cache source.Packages 2019-08-13 21:41:43 +00:00
rename.go internal/lsp: derive ASTs from type information 2019-09-10 13:53:09 +00:00
signature_help.go internal/lsp: derive ASTs from type information 2019-09-10 13:53:09 +00:00
source_test.go internal/lsp: only build a view when we have its configuration 2019-09-10 14:40:41 +00:00
suggested_fix.go internal/lsp: use protocol.TextEdits in suggested fixes 2019-09-07 02:01:28 +00:00
symbols.go internal/lsp: remove the GetToken and GetAST functions 2019-09-09 18:10:35 +00:00
util.go internal/lsp: derive ASTs from type information 2019-09-10 13:53:09 +00:00
view.go internal/lsp: start handling watched file deletes 2019-09-10 20:08:16 +00:00