1
0
mirror of https://github.com/golang/go synced 2024-11-14 15:00:27 -07:00
go/src/cmd/vet
Keith Randall 4958f9e2fe runtime: remove unused arm assembly for div/mod
Also add runtime· prefixes to the code that is still used.

Fixes #19507

Change-Id: Ib6da6b2a9e398061d3f93958ee1258295b6cc33b
Reviewed-on: https://go-review.googlesource.com/45699
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
2017-06-14 18:00:26 +00:00
..
all runtime: remove unused arm assembly for div/mod 2017-06-14 18:00:26 +00:00
internal
testdata cmd/vet: add a test for embedded stringer 2017-05-30 23:57:24 +00:00
asmdecl.go
assign.go
atomic.go
bool.go
buildtag.go cmd/vet: set exit status to non zero for all cases 2017-05-28 10:23:38 +00:00
cgo.go
composite.go
copylock.go
dead.go cmd/vet: skip unreachable "if" and "case" code in shift check. 2017-04-19 20:03:37 +00:00
deadcode.go
doc.go
httpresponse.go
lostcancel.go
main.go cmd/vet: skip unreachable "if" and "case" code in shift check. 2017-04-19 20:03:37 +00:00
method.go
nilfunc.go
print.go
rangeloop.go
README
shadow.go
shift.go cmd/vet: skip unreachable "if" and "case" code in shift check. 2017-04-19 20:03:37 +00:00
structtag.go
tests.go
types.go
unsafeptr.go
unused.go
vet_test.go

Vet is a tool that checks correctness of Go programs. It runs a suite of tests,
each tailored to check for a particular class of errors. Examples include incorrect
Printf format verbs or malformed build tags.

Over time many checks have been added to vet's suite, but many more have been
rejected as not appropriate for the tool. The criteria applied when selecting which
checks to add are:

Correctness:

Vet's tools are about correctness, not style. A vet check must identify real or
potential bugs that could cause incorrect compilation or execution. A check that
only identifies stylistic points or alternative correct approaches to a situation
is not acceptable.

Frequency:

Vet is run every day by many programmers, often as part of every compilation or
submission. The cost in execution time is considerable, especially in aggregate,
so checks must be likely enough to find real problems that they are worth the
overhead of the added check. A new check that finds only a handful of problems
across all existing programs, even if the problem is significant, is not worth
adding to the suite everyone runs daily.

Precision:

Most of vet's checks are heuristic and can generate both false positives (flagging
correct programs) and false negatives (not flagging incorrect ones). The rate of
both these failures must be very small. A check that is too noisy will be ignored
by the programmer overwhelmed by the output; a check that misses too many of the
cases it's looking for will give a false sense of security. Neither is acceptable.
A vet check must be accurate enough that everything it reports is worth examining,
and complete enough to encourage real confidence.